FE release [2024-07-17] #2881
FE release [2024-07-17] #2881
Conversation
- @synapsecns/[email protected]
- @synapsecns/[email protected] - [email protected]
ChiTimesChi
requested review from
dwasse,
trajan0x,
aureliusbtc,
bigboydiamonds and
abtestingalpha
as code owners
WalkthroughThe updates across various packages mainly involve version bumps and minor metadata changes. Notably, the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
github-actions
bot
added
go
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
- Corrected Ethereum explorer URL in
packages/synapse-constants/constants/chains/master.ts - Improved error messages with transaction ID in
services/rfq/guard/service/handlers.go - Added relayer address check in
services/rfq/relayer/service/handlers.go - Updated
synapse-constantsdependency inpackages/explorer-ui/package.json - Version bumps in
packages/explorer-ui/package.json,packages/synapse-constants/package.json, andpackages/synapse-interface/package.json
8 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
Deploying sanguine-fe with
|
| Latest commit: |
7cbb76f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://a34dc0d8.sanguine-fe.pages.dev |
| Branch Preview URL: | https://master.sanguine-fe.pages.dev |
There was a problem hiding this comment.
PR Summary
(updates since last review)
- Added
bridgeQuoteto analytics event payloads inpackages/synapse-interface/pages/state-managed-bridge/index.tsx - Enhanced store subscription events with
bridgeQuoteinpackages/synapse-interface/store/store.ts
2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (9)
- packages/explorer-ui/CHANGELOG.md (1 hunks)
- packages/explorer-ui/package.json (2 hunks)
- packages/synapse-constants/CHANGELOG.md (1 hunks)
- packages/synapse-constants/constants/chains/master.ts (1 hunks)
- packages/synapse-constants/package.json (1 hunks)
- packages/synapse-interface/CHANGELOG.md (1 hunks)
- packages/synapse-interface/package.json (1 hunks)
- services/rfq/guard/service/handlers.go (1 hunks)
- services/rfq/relayer/service/handlers.go (1 hunks)
Files skipped from review due to trivial changes (4)
- packages/explorer-ui/CHANGELOG.md
- packages/synapse-constants/CHANGELOG.md
- packages/synapse-interface/CHANGELOG.md
- packages/synapse-interface/package.json
Additional comments not posted (4)
packages/synapse-constants/package.json (1)
3-3: Version bump approved.The version update from
1.3.19to1.3.20appears to be a minor change, likely for routine updates or bug fixes.packages/explorer-ui/package.json (1)
3-3: Version and dependency updates approved.The version bump from
0.1.47to0.1.48and the update of thesynapse-constantsdependency to version1.3.20are both approved. These changes ensure consistency and compatibility within the project.Also applies to: 41-41
services/rfq/guard/service/handlers.go (1)
120-120: Enhanced error message approved.Including the transaction ID in the error message (
handleProveCalledfunction) enhances debugging and traceability. This is a valuable improvement for maintaining clarity in error logs.packages/synapse-constants/constants/chains/master.ts (1)
57-57: URL correction approved.The update of the
explorerUrlfor theETHchain from'https://etherscan.com'to'https://etherscan.io'corrects the URL to its proper domain. This change ensures that users and systems are directed to the correct service.
| if req.Relayer != r.signer.Address() { | ||
| return nil | ||
| } | ||
|
|
There was a problem hiding this comment.
Ensure proper authorization and state transition.
The addition of a conditional check to ensure the req.Relayer matches r.signer.Address() is crucial for security, ensuring that only the intended relayer can make the status update. This is a good practice to prevent unauthorized state changes.
However, the function should also verify that the previous status is ProvePosting before updating it to ProvePosted to ensure correct state transitions.
+ # Verify previous status before updating
+ current_status = r.db.GetQuoteRequestStatus(ctx, req.TransactionId)
+ if current_status != reldb.ProvePosting:
+ return fmt.Errorf("invalid state transition: current status is not ProvePosting")Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| if req.Relayer != r.signer.Address() { | |
| return nil | |
| } | |
| if req.Relayer != r.signer.Address() { | |
| return nil | |
| } | |
| # Verify previous status before updating | |
| current_status = r.db.GetQuoteRequestStatus(ctx, req.TransactionId) | |
| if current_status != reldb.ProvePosting: | |
| return fmt.Errorf("invalid state transition: current status is not ProvePosting") |
abtestingalpha
temporarily deployed
to
github-pages
Bundle ReportChanges will increase total bundle size by 3.51MB ⬆️
|
- @synapsecns/[email protected]
There was a problem hiding this comment.
PR Summary
(updates since last review)
- Version update for
@synapsecns/synapse-interfacepackage from 0.28.3 to 0.28.4 (packages/synapse-interface/package.json) - No major changes found since last review.
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (2)
- packages/synapse-interface/pages/state-managed-bridge/index.tsx (2 hunks)
- packages/synapse-interface/store/store.ts (1 hunks)
Additional comments not posted (2)
packages/synapse-interface/store/store.ts (1)
77-77: Addition ofbridgeQuotetoeventDatais approved, but verify integration.The addition of the
bridgeQuotefield to theeventDataobject is correctly implemented. However, ensure that this new data is correctly handled in all components that consumeeventData.packages/synapse-interface/pages/state-managed-bridge/index.tsx (1)
374-374: Addition ofbridgeQuoteto function payload is approved, but verify integration.The addition of the
bridgeQuoteparameter to the payload of the function call within theexecuteBridgefunction is correctly implemented. However, ensure that this new data is correctly handled in all components that consume this payload.Also applies to: 468-468
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (2)
- packages/synapse-interface/CHANGELOG.md (1 hunks)
- packages/synapse-interface/package.json (1 hunks)
Files skipped from review as they are similar to previous changes (2)
- packages/synapse-interface/CHANGELOG.md
- packages/synapse-interface/package.json
Description
A clear and concise description of the features you're adding in this pull request.
Additional context
Add any other context about the problem you're solving.
Metadata
Summary by CodeRabbit
New Features
Bug Fixes
explorerUrlfor the ETH chain fromhttps://etherscan.comtohttps://etherscan.io.Maintenance
@synapsecns/explorer-ui,@synapsecns/synapse-interface, andsynapse-constantsindicating routine maintenance with no functional changes.Compatibility
>=18.18.0for@synapsecns/synapse-interface.Data Handling Enhancements
StateManagedBridgecomponent and store subscription logic.0a77f76: explorer-ui preview link
0a77f76: synapse-interface preview link
cdb0f70: explorer-ui preview link
cdb0f70: synapse-interface preview link