Deploy RFQ FastBridge on BNB chain #2873
Conversation
WalkthroughThe recent updates focus on integrating support for the Binance Smart Chain (BNB) within the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
- Added
packages/contracts-rfq/deployments/bnb/.chainIdto specify BNB chain ID (56) - Added
packages/contracts-rfq/deployments/bnb/FastBridge.jsonwith deployment details for RFQ FastBridge on BNB - Updated
packages/contracts-rfq/foundry.tomlto include BNB RPC endpoints and Etherscan verification keys/URLs
3 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings
| { | ||
| "address": "0x5523D3c98809DdDB82C686E152F5C58B1B0fB59E", | ||
| "constructorArgs": "0x000000000000000000000000bd88862fcc17de436f7bd17276c537acadda9a67" | ||
| } |
There was a problem hiding this comment.
Style: Add a newline at the end of the file for better formatting.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (3)
- packages/contracts-rfq/deployments/bnb/.chainId (1 hunks)
- packages/contracts-rfq/deployments/bnb/FastBridge.json (1 hunks)
- packages/contracts-rfq/foundry.toml (1 hunks)
Files skipped from review due to trivial changes (2)
- packages/contracts-rfq/deployments/bnb/.chainId
- packages/contracts-rfq/deployments/bnb/FastBridge.json
Additional comments not posted (2)
packages/contracts-rfq/foundry.toml (2)
25-25: BNB RPC endpoint addition looks good.The addition of the BNB RPC endpoint is syntactically correct and appropriate for enabling interactions with the Binance Smart Chain.
33-33: BNB verifier configuration addition looks good.The addition of the BNB verifier configuration is syntactically correct and appropriate for enabling contract verification on the Binance Smart Chain.
Deploying sanguine-fe with
|
| Latest commit: |
cd8b4ea
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://0218c1cb.sanguine-fe.pages.dev |
| Branch Preview URL: | https://rfq-bnb.sanguine-fe.pages.dev |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2873 +/- ##
=============================================
Coverage 23.72299% 23.72299%
=============================================
Files 683 683
Lines 50959 50959
Branches 119 119
=============================================
Hits 12089 12089
Misses 37547 37547
Partials 1323 1323
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Bundle ReportChanges will decrease total bundle size by 11.08MB ⬇️
|
Description
A clear and concise description of the features you're adding in this pull request.
Additional context
Add any other context about the problem you're solving.
Metadata
Summary by CodeRabbit