fix 401 screner #2792
fix 401 screner #2792
Conversation
|
Warning Rate limit exceeded@golangisfun123 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 11 minutes and 2 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. WalkthroughThis update introduces a consistent data structure for handling blacklisted addresses across various components of the screener-api. A new Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
- Modified
BlackListBodystruct to include nestedDatastruct - Restructured
BlacklistedAddressstruct to embed newDatastruct - Updated
screener.goto access nested fields inblacklistBody.Data - Improved data organization and potentially fixed 401 unauthorized error
3 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
Deploying sanguine-fe with
|
| Latest commit: |
7c700a9
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://4c1b11f0.sanguine-fe.pages.dev |
| Branch Preview URL: | https://fix-data.sanguine-fe.pages.dev |
There was a problem hiding this comment.
PR Summary
(updates since last review)
- Updated
BlacklistedAddressstructure to include nestedDatastruct - Modified test cases in
db_test.goto align with new data model - Changed
blacklistTestWithOperationfunction to handleDataas a struct - Simplified creation and handling of
BlackListBodyinstances insuite_test.go
2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2792 +/- ##
===================================================
- Coverage 25.91883% 25.73669% -0.18215%
===================================================
Files 739 736 -3
Lines 53274 52804 -470
Branches 80 80
===================================================
- Hits 13808 13590 -218
+ Misses 38044 37818 -226
+ Partials 1422 1396 -26
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (6)
- .vscode/settings.json (1 hunks)
- contrib/screener-api/client/client.go (1 hunks)
- contrib/screener-api/db/db_test.go (1 hunks)
- contrib/screener-api/db/models.go (1 hunks)
- contrib/screener-api/screener/screener.go (4 hunks)
- contrib/screener-api/screener/suite_test.go (2 hunks)
Files skipped from review due to trivial changes (1)
- .vscode/settings.json
Additional context used
GitHub Check: Lint (contrib/screener-api)
contrib/screener-api/db/models.go
[failure] 13-13:
tag is not aligned, should be: gorm:"column:type" json:"type" (tagalign)
[failure] 15-15:
tag is not aligned, should be: gorm:"embedded" json:"data" (tagalign)contrib/screener-api/client/client.go
[failure] 122-122:
exported typeDatashould have comment or be unexported (golint)
Additional comments not posted (4)
contrib/screener-api/db/db_test.go (2)
14-21: Ensure correct initialization of nested structs in tests.The test initializes a
BlacklistedAddresswith nestedDatastruct correctly according to the new structure. Ensure all tests reflect this change.
33-33: Verify update logic in tests.The test modifies the
Remarkfield in theDatastruct and updates the database entry. Ensure this logic correctly reflects the intended behavior and that other fields can be similarly updated if needed.contrib/screener-api/screener/suite_test.go (1)
204-211: Ensure correct initialization of nested structs in integration tests.The test initializes a
BlackListBodywith nestedDatastruct correctly according to the new structure. This is crucial for ensuring that the integration tests are aligned with the actual data handling logic.contrib/screener-api/screener/screener.go (1)
280-294: Ensure attributes are correctly logged and data is handled properly inblacklistAddressmethod.The method correctly logs attributes and handles data according to the new structure. This is crucial for maintaining traceability and ensuring data integrity.
contrib/screener-api/db/models.go
Outdated
| Remark string `gorm:"column:remark" json:"remark"` | ||
| Type string `gorm:"column:type" json:"type"` | ||
| ID string `gorm:"column:id;primaryKey" json:"id"` | ||
| Data Data `gorm:"embedded" json:"data"` |
There was a problem hiding this comment.
Align GORM tags for consistency.
The GORM tag for the Data field in the BlacklistedAddress struct is misaligned. Aligning the tags properly ensures consistency and readability.
- Data Data `gorm:"embedded" json:"data"`
+ Data Data `gorm:"embedded" json:"data"`Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| Data Data `gorm:"embedded" json:"data"` | |
| Data Data `gorm:"embedded" json:"data"` |
Tools
GitHub Check: Lint (contrib/screener-api)
[failure] 15-15:
tag is not aligned, should be: gorm:"embedded" json:"data" (tagalign)
contrib/screener-api/db/models.go
Outdated
| Network string `gorm:"column:network" json:"network"` | ||
| Tag string `gorm:"column:tag" json:"tag"` | ||
| Remark string `gorm:"column:remark" json:"remark"` | ||
| Type string `gorm:"column:type" json:"type"` |
There was a problem hiding this comment.
Align GORM tags for consistency.
The GORM tag for the Type field in the BlacklistedAddress struct is misaligned according to the static analysis tool. Proper alignment improves readability and consistency.
- Type string `gorm:"column:type" json:"type"`
+ Type string `gorm:"column:type" json:"type"`Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| Type string `gorm:"column:type" json:"type"` | |
| Type string `gorm:"column:type" json:"type"` |
Tools
GitHub Check: Lint (contrib/screener-api)
[failure] 13-13:
tag is not aligned, should be: gorm:"column:type" json:"type" (tagalign)
There was a problem hiding this comment.
PR Summary
(updates since last review)
- Restructured
BlacklistedAddressmodel by removing nestedDatastruct - Updated
db_test.goto reflect newBlacklistedAddressstructure - Modified
PutBlacklistedAddressfunction to align with new model structure - Renamed variables in
namer.goto match updated model - Adjusted
screener.gofor newBlacklistedAddressinitialization and handling
5 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
There was a problem hiding this comment.
PR Summary
(updates since last review)
- Added support for custom font ligatures in the editor
- Restructured
BlackListBodyandBlacklistedAddressdata models to utilize a nestedDatastruct - Improved handling and initialization of
BlackListBodyin various functions and tests for better data management and readability
No file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
There was a problem hiding this comment.
PR Summary
(updates since last review)
- Restructured
BlackListBodyandBlacklistedAddressdata models to use a nestedDatastruct - Improved handling and initialization of
BlackListBodyfor better data management and readability - Introduced a new
Datastruct to encapsulate address-related fields - Minor formatting adjustments to struct tags in
BlacklistedAddressfor better readability
2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
Description
A clear and concise description of the features you're adding in this pull request.
Additional context
Add any other context about the problem you're solving.
Metadata
Summary by CodeRabbit
New Features
Refactor
BlackListBodyandBlacklistedAddressdata models to utilize a nestedDatastruct.Bug Fixes
BlackListBodyin various functions and tests for better data management and readability.