Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove service interrupted banner #1530

Merged
merged 2 commits into from
Nov 6, 2023
Merged

Remove service interrupted banner #1530

merged 2 commits into from
Nov 6, 2023

Conversation

bigboydiamonds
Copy link
Collaborator

@bigboydiamonds bigboydiamonds commented Nov 2, 2023

Summary by CodeRabbit

Refactor:

  • Removed the InterruptedServiceBanner component from the LandingPageWrapper component. This change simplifies the landing page layout and may result in a cleaner user interface.

2f234c64a3aca9184c7619f08bdb2551e1a07b3c: synapse-interface preview link
4b3cd8e2f1eb57d53ca3a0f4d89888e58cf884de: synapse-interface preview link

Copy link
Contributor

coderabbitai bot commented Nov 2, 2023

Walkthrough

The change primarily revolves around the removal of the InterruptedServiceBanner component from the LandingPageWrapper component in the Synapse Interface. This suggests a streamlined user interface, possibly due to improved service stability or a redesign of the notification system.

Changes

File Path Summary
.../layouts/LandingPageWrapper/index.tsx Removed the import and usage of InterruptedServiceBanner component

🐇🍂

As leaves fall and the air grows colder,
Our code becomes a tad bit bolder.
No more banners, interrupting the flow,
We've streamlined the interface, as smooth as a doe.

Celebrate the change, for it's a new dawn,
A cleaner design, like a fresh mown lawn.
So here's to the autumn, crisp and bright,
And to our code, light as a kite! 🎈🍁

Please note that the poem is a playful celebration of the changes and the current autumn season. It's meant to be inclusive and considerate of all cultures, and it's kept concise for easy reading.


Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • If you reply to a review comment from CodeRabbit, the bot will automatically respond.
  • To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
  • Note: Review comments are made on code diffs or files, not on the PR overview.
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai help to get help.
  • @coderabbitai resolve to resolve all the CodeRabbit review comments.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 523dcbb and 38717ef.
Files selected for processing (1)
  • packages/synapse-interface/components/layouts/LandingPageWrapper/index.tsx (2 hunks)
Files skipped from review due to trivial changes (1)
  • packages/synapse-interface/components/layouts/LandingPageWrapper/index.tsx

Copy link

codecov bot commented Nov 2, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (060df78) 51.57449% compared to head (91652e2) 51.00000%.
Report is 9 commits behind head on master.

Additional details and impacted files
@@                 Coverage Diff                 @@
##              master       #1530         +/-   ##
===================================================
- Coverage   51.57449%   51.00000%   -0.57449%     
===================================================
  Files            372         359         -13     
  Lines          25532       24400       -1132     
  Branches         281         283          +2     
===================================================
- Hits           13168       12444        -724     
+ Misses         11074       10748        -326     
+ Partials        1290        1208         -82     
Flag Coverage Δ
cctp-relayer ?
packages 91.00610% <100.00000%> (+0.12511%) ⬆️
promexporter ?
sinner ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
packages/sdk-router/src/operations/bridge.ts 100.00000% <100.00000%> (ø)
packages/sdk-router/src/router/routerSet.ts 95.55556% <ø> (ø)
...ages/sdk-router/src/router/synapseCCTPRouterSet.ts 100.00000% <100.00000%> (ø)
packages/sdk-router/src/router/synapseRouterSet.ts 100.00000% <100.00000%> (ø)
packages/sdk-router/src/router/types.ts 88.88889% <ø> (ø)
packages/sdk-router/src/sdk.ts 100.00000% <100.00000%> (ø)

... and 17 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

cloudflare-workers-and-pages bot commented Nov 2, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 91652e2
Status: ✅  Deploy successful!
Preview URL: https://3f075ea6.sanguine.pages.dev
Branch Preview URL: https://fe-remove-banner.sanguine.pages.dev

View logs

@bigboydiamonds bigboydiamonds merged commit 1070d14 into master Nov 6, 2023
49 checks passed
@bigboydiamonds bigboydiamonds deleted the fe/remove-banner branch November 6, 2023 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants