Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Icons] Support aliases in LockIconsCommand #2356

Merged
merged 1 commit into from
Nov 10, 2024
Merged

[Icons] Support aliases in LockIconsCommand #2356

merged 1 commit into from
Nov 10, 2024

Conversation

smnandre
Copy link
Member

@smnandre smnandre commented Nov 9, 2024

Q A
Bug fix? no
New feature? yes
Issues Fix #2354
License MIT

Alias icons are now all locked, and icon set aliases are supported too.

@carsonbot carsonbot added Feature New Feature Icons Status: Needs Review Needs to be reviewed labels Nov 9, 2024
@smnandre smnandre mentioned this pull request Nov 9, 2024
Closed
@smnandre
Copy link
Member Author

smnandre commented Nov 9, 2024

Test Failures unrelated (JS Map)

@smnandre smnandre requested review from Kocal and kbond and removed request for Kocal November 9, 2024 23:39
@carsonbot carsonbot added Status: Reviewed Has been reviewed by a maintainer and removed Status: Needs Review Needs to be reviewed labels Nov 9, 2024
kbond
kbond approved these changes Nov 9, 2024
View reviewed changes
Copy link
Member

@kbond kbond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@smnandre smnandre merged commit f329468 into symfony:2.x Nov 10, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kocal Kocal Kocal approved these changes

@kbond kbond kbond approved these changes

Assignees
No one assigned
Labels
Feature New Feature Icons Status: Reviewed Has been reviewed by a maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Icons] Add support for icon aliases during icon:lock command
4 participants
@smnandre @kbond @Kocal @carsonbot