[CI] Test ux.symfony.com with local UX packages #2063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kocal
force-pushed
the
ci/ux-symfony-com-real-ux-packages
branch
10 times, most recently
from
354456d
to
dc0796a
Compare
Kocal
force-pushed
the
ci/ux-symfony-com-real-ux-packages
branch
5 times, most recently
from
d29c52c
to
58d1d20
Compare
|
I think we need both (one to check all components with their "current dev version"... but also one like before, to simulate if aa user checks @dev with stable components), no ? (not for the ux website probably, but the build package is used for all tests right ? ) |
Nothing changed here, packages tests are still running like before (by using the "local" packages). This same behaviour has been applied to ux.symfony.com project to take advantage of installing (and testing a bit) our UX packages in a real application. |
kbond
force-pushed
the
ci/ux-symfony-com-real-ux-packages
branch
from
58d1d20
to
1386749
Compare
|
Thanks Hugo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #1965 and #2060, I was a bit surprised to see ux.symfony.com tests were executed with UX packages coming from
2.xbranch, instead of UX packages from the same PR.I believe doing this could help us for the future and prevent some regressions.
I've updated the script
.github/build-packages.phpto automatically replaces all UX packages requires(-dev) from all significantcomposer.jsonfiles from the repo: