-
Notifications
You must be signed in to change notification settings - Fork 48
[WIP] Start new SE #1
Conversation
Also removed 2.4 features
we may want to switch to https://github.com/doctrine/DoctrineCacheBundle |
@lsmith77 I agree that it's better to use a Doctrine bundle here. However, I would like to only use stable libraries in the SE. Is there a change it gets stable before CMF 1.1 is released? |
it has been released as stable a few days ago |
@lsmith77 hmm, not on packagist afaics: https://packagist.org/packages/doctrine/doctrine-cache-bundle |
oh .. you are right .. pinged them again. will follow up |
FYI created a PR on the sandbox to switch to the doctrine cache bundle symfony-cmf/cmf-sandbox#241 |
So, I've added the block bundle and improved the homepage. There is only one major issue: I can't run the I also want to know how I can include the homepage in the menu, since it's the parent of all routes. |
btw DoctrineCacheBundle 1.0.0 stable is released I will check into the server:run issue tonight. |
@lsmith77 yes, it would be great if you can do that. After that and the menu thing, this PR can be merged. I consider the other things optional, they are not really needed for the SE. |
don't we have the initializer create a Route at /cms/routes? since 1.1 |
ok .. i have added DoctrineCacheBundle. |
from my POV some tests are a must have .. though I guess we can take the current SE tests and adapt them. also I guess the README needs to be updated with some infos, though I am not sure if we want to keep as much info in there or not delegate to the docs more. |
+1 for moving most of our doc from the README to the documentation. |
I still can't get server:run working... |
i added some basic tests. as for the run command, maybe kill your vendors? also what error are you getting? |
I've removed the project from my system and cloned it again and installed vendors. So I have a fresh clone, without caches/logs/db/etc. Now, when I run |
does the server run command work in other symfony projects without issues? |
yes (that's the strangest part) |
can you update the routing/simple cms bundles? |
cmf_simple_cms: | ||
routing: | ||
templates_by_class: | ||
Symfony\Cmf\Bundle\SimpleCmsBundle\Doctrine\Phpcr\Page: AcmeDemoBundle:Page:index.html.twig |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thos now has to move to cmf_routing
It should be ready now:
|
This is the PR creating the new CMF SE. I've based it on the 2.3 branch of the core SE, because 2.3 is the LTS version. We may need to release a version including the 2.4?
Reducing
That's the keyword of this PR. It tries to reduce the old CMF SE. What I've removed:
I've also tried to keep the code as easy to understand as possible.
Todo
/cc @dbu @dantleech @lsmith77