Skip to content
This repository has been archived by the owner on Sep 16, 2021. It is now read-only.

[WIP] Start new SE #1

Merged
merged 23 commits into from
Apr 4, 2014
Merged

[WIP] Start new SE #1

merged 23 commits into from
Apr 4, 2014

Conversation

wouterj
Copy link
Member

@wouterj wouterj commented Mar 2, 2014

Q A
Fixed tickets https://github.com/symfony-cmf/symfony-cmf-standard/issues/31, https://github.com/symfony-cmf/symfony-cmf-standard/issues/42
License MIT
Doc PR todo (mainly quick tour)

This is the PR creating the new CMF SE. I've based it on the 2.3 branch of the core SE, because 2.3 is the LTS version. We may need to release a version including the 2.4?

Reducing

That's the keyword of this PR. It tries to reduce the old CMF SE. What I've removed:

  • Multi-language
  • Media
  • Imagine

I've also tried to keep the code as easy to understand as possible.

Todo

/cc @dbu @dantleech @lsmith77

@lsmith77
Copy link
Member

lsmith77 commented Mar 2, 2014

we may want to switch to https://github.com/doctrine/DoctrineCacheBundle

@wouterj
Copy link
Member Author

wouterj commented Mar 10, 2014

@lsmith77 I agree that it's better to use a Doctrine bundle here. However, I would like to only use stable libraries in the SE. Is there a change it gets stable before CMF 1.1 is released?

@lsmith77
Copy link
Member

it has been released as stable a few days ago

@wouterj
Copy link
Member Author

wouterj commented Mar 10, 2014

@lsmith77 hmm, not on packagist afaics: https://packagist.org/packages/doctrine/doctrine-cache-bundle

@lsmith77
Copy link
Member

oh .. you are right .. pinged them again. will follow up

@lsmith77
Copy link
Member

FYI created a PR on the sandbox to switch to the doctrine cache bundle symfony-cmf/cmf-sandbox#241

@wouterj
Copy link
Member Author

wouterj commented Mar 26, 2014

So, I've added the block bundle and improved the homepage.

There is only one major issue: I can't run the php app/console server:run command anymore with this project. Can somebody please clone this repo locally and check if it works for them?

I also want to know how I can include the homepage in the menu, since it's the parent of all routes.

@lsmith77
Copy link
Member

btw DoctrineCacheBundle 1.0.0 stable is released
i guess i should add it and enable it by default just like I did in the sandbox?

I will check into the server:run issue tonight.

@wouterj
Copy link
Member Author

wouterj commented Mar 26, 2014

@lsmith77 yes, it would be great if you can do that. After that and the menu thing, this PR can be merged. I consider the other things optional, they are not really needed for the SE.

@dbu
Copy link
Member

dbu commented Mar 26, 2014

I also want to know how I can include the homepage in the menu, since
it's the parent of all routes.

don't we have the initializer create a Route at /cms/routes? since 1.1
initializers can create objects. ah, in the sandbox we have nothing at
/cms/routes and its handled by lunetics locale i think...

@lsmith77
Copy link
Member

ok .. i have added DoctrineCacheBundle.
server:run ran fine for me .. maybe its fixed with the composer update I did?

@lsmith77
Copy link
Member

from my POV some tests are a must have .. though I guess we can take the current SE tests and adapt them. also I guess the README needs to be updated with some infos, though I am not sure if we want to keep as much info in there or not delegate to the docs more.

@dbu
Copy link
Member

dbu commented Mar 26, 2014

+1 for moving most of our doc from the README to the documentation.

@wouterj
Copy link
Member Author

wouterj commented Mar 27, 2014

I still can't get server:run working...

@lsmith77
Copy link
Member

i added some basic tests.

as for the run command, maybe kill your vendors? also what error are you getting?

@wouterj
Copy link
Member Author

wouterj commented Mar 27, 2014

I've removed the project from my system and cloned it again and installed vendors. So I have a fresh clone, without caches/logs/db/etc.

Now, when I run php app/console server:run I get "Server running on http://localhost:8000" and after 2 seconds, the script stops. No errors, no logs.

@lsmith77
Copy link
Member

does the server run command work in other symfony projects without issues?

@wouterj
Copy link
Member Author

wouterj commented Mar 27, 2014

yes (that's the strangest part)

@lsmith77
Copy link
Member

lsmith77 commented Apr 3, 2014

can you update the routing/simple cms bundles?

cmf_simple_cms:
routing:
templates_by_class:
Symfony\Cmf\Bundle\SimpleCmsBundle\Doctrine\Phpcr\Page: AcmeDemoBundle:Page:index.html.twig
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thos now has to move to cmf_routing

@wouterj
Copy link
Member Author

wouterj commented Apr 3, 2014

It should be ready now:

  • The data fixture now adds a MenuNode for the Home menu item
  • Removed all useless assets
  • Updated for latest SimpleCms/Routing changes
  • Removed the app/app.sqlite file

lsmith77 added a commit that referenced this pull request Apr 4, 2014
@lsmith77 lsmith77 merged commit e5677bd into master Apr 4, 2014
@lsmith77 lsmith77 deleted the start_se branch April 4, 2014 14:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants