This repository has been archived by the owner on Sep 16, 2021. It is now read-only.
DevKit updates #139
Open
DevKit updates #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ElectricMaxxx
force-pushed
the
master-dev-kit
branch
from
85569b3 to
12744bc
Compare
ElectricMaxxx
force-pushed
the
master-dev-kit
branch
from
12744bc to
5d0be79
Compare
ElectricMaxxx
force-pushed
the
master-dev-kit
branch
from
484ff40 to
493bfa4
Compare
dbu
reviewed
Jan 30, 2019
.travis.yml
Outdated
| - KERNEL_CLASS=Symfony\Cmf\Bundle\SonataPhpcrAdminIntegrationBundle\Tests\Fixtures\App\Kernel | ||
| - SYMFONY_PHPUNIT_VERSION=5.7 | ||
| - TEST_INSTALLATION=false | ||
| - KERNEL_CLASS="Symfony\Cmf\Bundle\SonataPhpcrAdminIntegrationBundle\Tests\Fixtures\App\Kernel" |
There was a problem hiding this comment.
please move this into phpunit.xml.dist so the tests run locally. you can remove KERNEL_DIR in phpunit.xml.dist, because that is no longer used.
There was a problem hiding this comment.
btw: the variable is also exported in make file :-)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's make it stable here