This repository has been archived by the owner on Sep 16, 2021. It is now read-only.
do not report deprecations in vendors #132
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By supressing them, we won't be able to see what will break in SF4 expept from testing in SF4 |
|
i think its a useful step to get forward and better see what is going on with the code of this repo. but if you disagree, we can drop this PR. |
|
No, you got me. going forward and see the errors is easier. |
|
so we switched our opinions at the same time 😄 okay lets merge this then. |
ElectricMaxxx
suggested changes
May 16, 2018
| @@ -28,7 +28,7 @@ cache: | |||
| env: | |||
| matrix: SYMFONY_VERSION=4.0.* | |||
| global: | |||
| - SYMFONY_DEPRECATIONS_HELPER=0 | |||
| - SYMFONY_DEPRECATIONS_HELPER=weak_vendors | |||
There was a problem hiding this comment.
this should be done by our dev-kit
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this setting should limit deprecation notices to the code of this package and hide everything happening in the vendors.
refs #130