-
Notifications
You must be signed in to change notification settings - Fork 27
option to disable guessers/loaders/voters globaly #245
Conversation
for sitemap specific, we could have the same config in each configuration, and update the service tags with the sitemap attribute. but yeah, lets leave that out for now. i would invert i would make the configuration options arrayNode instead of comma separated. we can have a pre-task to convert a single string with "all" or also "...loader.phpcr" to an array. i wonder if all/none could clash with a sitemap name. maybe use _all / _none? or something else that is very unlikely to be a sitemap? particularly |
oh, and lets start a separate doc PR so we get the first one merged at some point... |
@dbu as the issue starts with I started implementing the configuration as an To set the same option into each sitemap would be not the problem, to disable the services for more then one sitemap, would be very hard. I would imagine to steel the service caused by the option on one sitemap and an other still whants the service ... So lets just keep it global for now. |
@dbu i don't understand the thing with mixing sitemap names and all|none the options never touch a sitemap by its name. in the worst case a service with the id all|none can't be implemented. |
@@ -1,6 +1,7 @@ | |||
Changelog | |||
========= | |||
|
|||
* **2015-07-30**: implement options to enable/disable guessers, loaders and voters |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i would just add that to the rest of the sitemap thing
96e959d
to
6f621be
Compare
@dbu we should merge that, right? |
434fb20
to
023acde
Compare
i squashed commits. i think its now ready to merge. i created a separate issue for the doc, so that we don't block the initial doc PR any longer. |
…disable option to disable guessers/loaders/voters globaly
Started implementing with that and came to an easy global on/off/partial-off solution, we can start with. Doing some fance inheritance into the specific sitemap configurations will be an overkill atm - i think.
When you like that, i will do: