[AdminExtension] Add link to page in frontend if possible #273
Conversation
| ); | ||
| } | ||
|
|
||
| $uri = $this->router->generate($subject); |
There was a problem hiding this comment.
i think we should wrap a try-catch around this. for example when the $subject does implement the interface but has no route pointing to it yet. when there is an exception, simply return.
|
thanks a lot! coming good. i added a few comments. for the doc, i think we have to document this in http://symfony.com/doc/master/cmf/bundles/routing/dynamic.html#routereferrersinterface-sonata-admin-extension and could start to use this in http://symfony.com/doc/master/cmf/tutorial/sonata-admin.html |
- Added translation - Shortened caption and added title - Routes can now also be linked to the frontend - Improved exception handling
…speaking should really review it.
|
Added XLIFF translations for the new strings, but it should seriously be reviewed by someone who fluently speaks those languages (fr, it, nl, pl). |
|
thanks a lot. translations look good enough to me. where did you want to add the css to show this in a more interesting way? in the sandbox? |
|
I would have placed it into the sandbox, or is there a more common place for such things? |
dbu
changed the title
[AdminExtension] Add link to page in frontend if possible
|
thanks! can you add the css in the sandbox and also provide a sample in the documentation? i created an issue for the documentation symfony-cmf/symfony-cmf-docs#609 |
|
Cool. I'll add the css to symfony-cmf/cmf-sandbox/pull/276 |
SonataAdmin extension which adds a link to the frontend page on documents with a route.
Default configuration for the extension here: symfony-cmf/cmf-sandbox#276