Skip to content
This repository has been archived by the owner on Sep 16, 2021. It is now read-only.

Removed type hint to enable redirect target to be a content document #56

Merged
merged 2 commits into from
Oct 28, 2015
Merged

Removed type hint to enable redirect target to be a content document #56

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
517784a
Removed type hint to enable redirect target to be a content document
dantleech Sep 15, 2015
1e43b5f
Explicitely state that the change is a BC Break
wouterj Oct 28, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@ Changelog
dev-master
----------

* **2015-09-15**: Removed type hint from `AutoRouteInterface::setRedirectTarget` to allow
redirect target to be a content document.
* **2015-09-05**: "Leave Redirect" defunct route handler now migrates any children
of the original route.
* **2015-08-23**: `AdapterInterface::translateObject()` now has to return the
Expand Down
4 changes: 2 additions & 2 deletions Model/AutoRouteInterface.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,12 +59,12 @@ public function getAutoRouteTag();
public function setType($mode);

/**
* For use in the REDIRECT mode, specifies the AutoRoute
* For use in the REDIRECT mode, specifies the routable object
* that the AutoRoute should redirect to.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe specify who's job it is to ensure that $autoTarget is a valid target?

*
* @param AutoRouteInterface AutoRoute to redirect to.
*/
public function setRedirectTarget(AutoRouteInterface $autoTarget);
public function setRedirectTarget($autoTarget);

/**
* Return the redirect target (when the auto route is of type
Expand Down