-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding new 'cmf_media_file' form type #137
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,94 @@ | ||
<?php | ||
|
||
/* | ||
* This file is part of the Symfony CMF package. | ||
* | ||
* (c) 2011-2014 Symfony CMF | ||
* | ||
* For the full copyright and license information, please view the LICENSE | ||
* file that was distributed with this source code. | ||
*/ | ||
|
||
namespace Symfony\Cmf\Bundle\MediaBundle\Form\Type; | ||
|
||
use Symfony\Cmf\Bundle\MediaBundle\File\UploadFileHelperInterface; | ||
use Symfony\Cmf\Bundle\MediaBundle\Form\DataTransformer\ModelToFileTransformer; | ||
use Symfony\Component\Form\AbstractType; | ||
use Symfony\Component\Form\FormBuilderInterface; | ||
use Symfony\Component\OptionsResolver\OptionsResolver; | ||
use Symfony\Component\OptionsResolver\OptionsResolverInterface; | ||
|
||
/** | ||
* Form type which transforms an uploaded file to an object implementing the | ||
* Symfony\Cmf\Bundle\MediaBundle\FileInterface | ||
* | ||
* It renders as a file upload button with a link for downloading the existing | ||
* file, if any. | ||
* | ||
* Usage: you need to supply the object class to which the file will be | ||
* transformed (which should implement FileInterface) and an UploadFileHelper, | ||
* which will handle the UploadedFile and create the transformed object. | ||
*/ | ||
class FileType extends AbstractType | ||
{ | ||
/** | ||
* @var string | ||
*/ | ||
protected $dataClass; | ||
|
||
/** | ||
* @var UploadFileHelperInterface | ||
*/ | ||
protected $uploadFileHelper; | ||
|
||
/** | ||
* @param string $class | ||
* @param UploadFileHelperInterface $uploadFileHelper | ||
*/ | ||
public function __construct($class, UploadFileHelperInterface $uploadFileHelper) | ||
{ | ||
$this->dataClass = $class; | ||
$this->uploadFileHelper = $uploadFileHelper; | ||
} | ||
|
||
/** | ||
* {@inheritdoc} | ||
*/ | ||
public function getParent() | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. please add |
||
{ | ||
return 'file'; | ||
} | ||
|
||
/** | ||
* {@inheritdoc} | ||
*/ | ||
public function getName() | ||
{ | ||
return 'cmf_media_file'; | ||
} | ||
|
||
/** | ||
* {@inheritdoc} | ||
*/ | ||
public function buildForm(FormBuilderInterface $builder, array $options) | ||
{ | ||
$transformer = new ModelToFileTransformer($this->uploadFileHelper, $options['data_class']); | ||
$builder->addModelTransformer($transformer); | ||
} | ||
|
||
/** | ||
* {@inheritdoc} | ||
*/ | ||
public function setDefaultOptions(OptionsResolverInterface $options) | ||
{ | ||
$this->configureOptions($options); | ||
} | ||
|
||
/** | ||
* {@inheritdoc} | ||
*/ | ||
public function configureOptions(OptionsResolver $options) | ||
{ | ||
$options->setDefaults(array('data_class' => $this->dataClass)); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add a docblock for the class, explaining what this is (mainly why we need this on top of the standard file type). i know that the existing code is not setting a good example, but lets try to improve things.