Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version upgrades #59

Closed
wants to merge 11 commits into from
Closed

Version upgrades #59

wants to merge 11 commits into from

Conversation

dbu
Copy link
Member

@dbu dbu commented Mar 25, 2015

continue #58

I did not adress these issues listed in #58

  • Make sure configuration is loadable when defined as XML
  • The XML schema file for the config is out-of-date with Configuration
  • Translatable content. It might work; untested.

i suggest we just create issues for that and don't try to do that in this PR.

composer.lock
vendor
vendor/
.idea
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did we not say not to include IDE specifc things in the ignore file?

@dbu dbu force-pushed the version_upgrades branch from f577693 to 09de934 Compare March 26, 2015 07:52
@lsmith77
Copy link
Member

+1 for merging as is and opening tickets for the other stuff

@dbu
Copy link
Member Author

dbu commented Mar 29, 2015

as we use the phpcr_document form type, this is blocked by doctrine/DoctrinePHPCRBundle#193

@aitboudad
Copy link

you should rename rdf mappings file of Post to

Symfony.Cmf.Bundle.BlogBundle.Doctrine.Phpcr.Post.xml

@lsmith77
Copy link
Member

@aitboudad thanks .. done

rsa
@@ -0,0 +1,27 @@
-----BEGIN RSA PRIVATE KEY-----
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

huh?

@dbu
Copy link
Member Author

dbu commented Jun 1, 2015

and we seem to have a conflict between routing auto and the routing auto bundle

@lsmith77 lsmith77 force-pushed the version_upgrades branch 2 times, most recently from 64c46a6 to 1107e6a Compare June 5, 2015 09:17
@lsmith77 lsmith77 force-pushed the version_upgrades branch from 1107e6a to 8482b4e Compare June 5, 2015 09:21

env:
- SYMFONY_VERSION=2.5.*

- SYMFONY_VERSION=2.7.* SYMFONY_DEPRECATIONS_HELPER=weak
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are we sure we removed all deprecated usages from this bundle?

@dbu
Copy link
Member Author

dbu commented Aug 24, 2015

locally the slugifier did not work as expected. lets see if it gets better on travis.

@dbu dbu mentioned this pull request Dec 17, 2015
@dbu dbu closed this Apr 8, 2016
@lsmith77 lsmith77 removed the review label Apr 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants