-
Notifications
You must be signed in to change notification settings - Fork 51
Update ImagineBlock to use CmfMedia image #72
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -10,7 +10,7 @@ | |
{% if block.linkUrl is defined %} | ||
<a href="{{ block.linkUrl }}" title="{{ block.label|default('') }}"> | ||
{% endif %} | ||
<span id="label">{{ block.label }}</span><img src="{{ block.image | imagine_filter(filter) }}" alt="{{ block.label }}" /> | ||
<span id="label">{{ block.label }}</span><img src="{{ block.image.id | imagine_filter(filter) }}" alt="{{ block.label }}" /> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. uh, i think the current imagine phpcr binding can accept an image object. if we change to this here, it means that it won't work with the phpcr provider that is built into imagine... i guess that is ok, but we might want to mention this in the doc. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It will use the There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. i thought the current imagine thingy gets the object and directly There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. checked and it will not work if we do not specify the id explicitly, also updated documentation and the changelog for this |
||
{% if block.linkUrl is defined %} | ||
</a> | ||
{% endif %} | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,21 +1,19 @@ | ||
{% extends sonata_block.templates.block_base %} | ||
|
||
{% block block %} | ||
<div class="span3"> | ||
<h2>{{ settings.title }}</h2> | ||
<p>This block displays a list of messages based on this <a href="{{ settings.url }}" title="Url rss block">rss feed</a>.</p> | ||
<h2>{{ settings.title }}</h2> | ||
<p>This block displays a list of messages based on this <a href="{{ settings.url }}" title="Url rss block">rss feed</a>.</p> | ||
|
||
<div class="feed-container"> | ||
{% for item in items %} | ||
<ul> | ||
<li> | ||
<a class="item-link" href="{{ item.link}}" rel="nofollow" title="{{ item.title }}">{{ item.title }}</a> | ||
(<span class="item-pubdate">{{ item.pubDate | date('Y-m-d') }}</span>) | ||
</li> | ||
</ul> | ||
{% else %} | ||
No feeds available. | ||
{% endfor %} | ||
</div> | ||
<div class="feed-container"> | ||
{% for item in items %} | ||
<ul> | ||
<li> | ||
<a class="item-link" href="{{ item.link}}" rel="nofollow" title="{{ item.title }}">{{ item.title }}</a> | ||
(<span class="item-pubdate">{{ item.pubDate | date('Y-m-d') }}</span>) | ||
</li> | ||
</ul> | ||
{% else %} | ||
No feeds available. | ||
{% endfor %} | ||
</div> | ||
{% endblock %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think we have agreed on not omitting the
()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah ok, will do that in future