Allow rest base 32 addresses #804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fboucquez
force-pushed
the
rest_plain_addresses
branch
from
cc7f8e6
to
8a709a9
Compare
12 tasks
fboucquez
changed the title
fboucquez
force-pushed
the
rest_plain_addresses
branch
from
8a709a9
to
f90260c
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
AnthonyLaw
reviewed
Oct 3, 2021
| * @return the Address object. | ||
| */ | ||
| public static toAddress(value: string): Address { | ||
| return Convert.isHexString(value, 48) ? Address.createFromEncoded(value) : Address.createFromRawAddress(value); |
There was a problem hiding this comment.
Example in transfer transaction, If the recipientAddress is alias THBIMC3THGH5RUYAAAAAAAAAAAAAAAAAAAAAAAA
It will throw an error Address Network unsupported right?
There was a problem hiding this comment.
We haven't removed private/mijin network support from the old SDKs yet. Unsure if it makes sense to remove them, this SDK would fade off eventually.
There was a problem hiding this comment.
Ignore my question.
Actually, I misunderstood, even though the alias namespace is still converted to a valid address format from REST.
AnthonyLaw
approved these changes
Oct 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the SDK side of symbol/catapult-rest#611
The new rest mappers will accept both encoded/hex and plain/decoded addresses. It will buffer the migration allowing the SDK rest client to be compatible with old and new rests. Eventually, we should only allow base32 addresses. Apps only need to upgrade the SDK, no code change is required.
A migration plan could be:
No flag is required.
Related issues:
#801
#802