fix: UnhandledPromiseRejection errors #782
Conversation
Simplified exception handling. Defer when loading node info metadata --unhandled-rejections=strict in tests Exception handling simplification
| const repositoryFactory = new RepositoryFactoryHttp(url); | ||
| try { | ||
| await repositoryFactory.createNodeRepository().getNodeHealth().toPromise(); | ||
| expect(true).to.be.false; |
There was a problem hiding this comment.
Should we use chai-as-promised or a similar promise assertion library as a better practice in general for promise assertions?
There was a problem hiding this comment.
Thanks! chai as promises looks nice. Although the try-catch could be more end-user-style assertion? And I wouldn't add another lib just yet. Let's consider it for the future.
| @@ -70,6 +72,17 @@ describe('RepositoryFactory', () => { | |||
| expect(repositoryFactory.createFinalizationRepository()).to.be.not.null; | |||
| }); | |||
|
|
|||
| it('Raise error without unhandled-rejections', async () => { | |||
| const url = 'https://www.google.com'; | |||
There was a problem hiding this comment.
Any other way to achieve this without relying on a remote call? I think we can use sinon to stub the getNodeHealthmethod to throw an error.
There was a problem hiding this comment.
TS SDK uses ts-mockito. I've mocked the low-level generated NodeRoutesApi reflecting how it rejects responses with the current mock lib. The (nodeRepository as any).nodeRoutesApi doesn't look nice, but well.
Exception handling simplification in http calls
Defer when loading node info metadata
--unhandled-rejections=strict in tests
Fixes #781