You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When a user is creating an address, the constructor should be validating the checksum by default and not expect the user to call Address.isValidRawAddress before...
createFromRawAddress - imo it should not do validation, you should be able anything that has size of raw address...
if user (read: developer) wants to validate, there should be explicit call to isValid()
When a user is creating an address, the constructor should be validating the checksum by default and not expect the user to call Address.isValidRawAddress before...
https://github.com/symbol/symbol-sdk-typescript-javascript/blob/main/src/model/account/Address.ts#L45
Note, I've added the validation and this breaks several invalid unit tests where the addresses are invalid.
The text was updated successfully, but these errors were encountered: