[tools/shoestring]: allow collect of multiple certificates date #527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## shoestring/dev #527 +/- ##
===============================================
Coverage 98.18% 98.19%
===============================================
Files 155 155
Lines 6297 6307 +10
Branches 143 143
===============================================
+ Hits 6183 6193 +10
Misses 114 114
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Jaguar0625
reviewed
Jul 26, 2023
tools/shoestring/shoestring/healthagents/rest_https_certificate.py
Outdated
Show resolved
Hide resolved
tools/shoestring/shoestring/healthagents/rest_https_certificate.py
Outdated
Show resolved
Hide resolved
Jaguar0625
approved these changes
Jul 26, 2023
There was a problem hiding this comment.
looks good to me but wait for @gimre-xymcity review before merging
| '-in', temp_file | ||
| '-noout', | ||
| '-certs', | ||
| temp_file | ||
| ], command_input='Q', show_output=False) |
There was a problem hiding this comment.
this probably should not require command input ?
Jaguar0625
force-pushed
the
shoestring/dev
branch
from
78f2270
to
8ef352e
Compare
Jaguar0625
force-pushed
the
fix/allow_collect_mulitple_cert_dates
branch
from
ad3fa17
to
5ddc55b
Compare
Jaguar0625
force-pushed
the
fix/allow_collect_mulitple_cert_dates
branch
from
9e2da98
to
8a114c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to use
openssl storeutlto parse all certificates instead ofopenssl x509which only returns information for the first.openssl storeutlwill fail if the input is not a valid pem, extract the certificate information from the output ofopenssl s_client.