Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

harvesting page improvements, nodePublicKey and multi-device support #1781

Merged
merged 7 commits into from
Nov 23, 2021
Merged

harvesting page improvements, nodePublicKey and multi-device support #1781

merged 7 commits into from
Nov 23, 2021

Conversation

yilmazbahadir
Copy link
Contributor

@yilmazbahadir yilmazbahadir commented Nov 22, 2021 •
edited
Loading

fixes #1762

  • find node by nodePublicKey from stats service
  • multi-device operation support

harvesting page improvements, nodePublicKey and multi-device support
d64bec9 
find node by nodePublicKey from stats service
multi-device operation support
rg911
rg911 reviewed Nov 22, 2021
View reviewed changes
src/services/NodeService.ts
} catch (error) {
console.log(error);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need to send to the form?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the comment mate, what do you mean by form?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean if it errors out, should the frontend show sth in the notification popup?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, undefined is returned in such cases, and the frontend handles that.

@lgtm-com
Copy link

lgtm-com bot commented Nov 22, 2021

This pull request introduces 1 alert when merging cffdf37 into e1103f8 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Nov 22, 2021

This pull request introduces 1 alert when merging eb953a9 into e1103f8 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Nov 22, 2021

This pull request introduces 1 alert when merging 866aa32 into e1103f8 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@yilmazbahadir yilmazbahadir force-pushed the feat/harvesting-stats-service-improvements branch from 866aa32 to 613336e Compare November 22, 2021 23:29
@yilmazbahadir yilmazbahadir force-pushed the feat/harvesting-stats-service-improvements branch from 0201308 to a120374 Compare November 23, 2021 07:59
@sonarcloud
Copy link

sonarcloud bot commented Nov 23, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@yilmazbahadir yilmazbahadir merged commit d59ace8 into dev Nov 23, 2021
@yilmazbahadir yilmazbahadir deleted the feat/harvesting-stats-service-improvements branch November 23, 2021 15:04
This was referenced Dec 3, 2021
Merged
Merged
@cryptoBeliever cryptoBeliever mentioned this pull request Dec 20, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cryptoBeliever cryptoBeliever cryptoBeliever approved these changes

@rg911 rg911 rg911 approved these changes

@AnthonyLaw AnthonyLaw Awaiting requested review from AnthonyLaw

@bassemmagdy bassemmagdy Awaiting requested review from bassemmagdy

@OlegMakarenko OlegMakarenko Awaiting requested review from OlegMakarenko

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Harvesting - improvements using statistics service - query node by nodePublicKey
3 participants
@yilmazbahadir @rg911 @cryptoBeliever