ENH Update code to reflect changes in template layer #556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
23 tasks
GuySartorelli
force-pushed
the
pulls/7/refactor-template-layer
branch
2 times, most recently
from
cf4085c to
18db146
Compare
GuySartorelli
force-pushed
the
pulls/7/refactor-template-layer
branch
from
18db146 to
fe97782
Compare
GuySartorelli
commented
Oct 23, 2024
| @@ -134,10 +136,7 @@ public function execute(WorkflowInstance $workflow) | |||
| ]); | |||
| } | |||
|
|
|||
|
|
|||
| $view = SSViewer::fromString($this->EmailTemplate); | |||
| $this->extend('updateView', $view); | |||
There was a problem hiding this comment.
Not sure what anyone would have used that extension point for, but it wouldn't be useful now we're not using SSViewer at all anyway.
GuySartorelli
commented
Oct 23, 2024
| @@ -146,7 +145,7 @@ public function execute(WorkflowInstance $workflow) | |||
| $item->Assignee = ArrayData::create($assigneeVars); | |||
| } | |||
|
|
|||
| $body = $view->process($item); | |||
| $body = $engine->renderString($this->EmailTemplate, ViewLayerData::create($item)); | |||
There was a problem hiding this comment.
The EmailTemplate value isn't hardcoded, so could be updated at a project level to be whatever template syntax the devs want to use, therefore use TemplateEngine not explicitly SSTemplateEngine
emteknetnz
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relies and reflects on changes in silverstripe/silverstripe-framework#11405
Issue