-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Image / Index by Matcher #88
Conversation
99f8a1f
to
376ac47
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we support retrieving images/indexes by properties other than the org.opencontainers.image.ref.name
annotation?
A few potential use cases I can foresee:
- Retrieve by digest. The current API supports this by supplying a
name.Digest
, but this attempts to match theorg.opencontainers.image.ref.name
annotation rather than the digest in the descriptor? - Retrieve an image from a multi-arch index. If I have a root index that points to a multi-arch index, should I be able to retrieve an image by supplying the reference (of the index) and the platform (of the image)?
- Retrieve by artifact type. For example, in a SIF with an OCI artifact and then other artifacts that reference it, I might want to retrieve the "base" artifact by its type?
Rewritten so the functions take the Look okay to you? |
Ahh sorry - yeah 2. is nested index so this doesn't work directly, as you pointed out in Slack. |
Alright, as discussed in huddle... let's take a |
Allow an Image or ImageIndex to be retrieved from a SIF file by Matcher - e.g. match.Name(..) to match by ref.name annotation. Fixes sylabs#82
Allow an Image or ImageIndex to be retrieved from a SIF file by Matcher - e.g. match.Name(..) to match by ref.name annotation.
Fixes #82