-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add: override artifactType #74
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One question and suggestion about the naming of the API. Thanks!
All your suggestions I initially had, but changed it. Since I'm only setting the artifact type on the config I opted for the name structure. Let's huddle tomorrow if you have time. |
Signed-off-by: Adrian Wobito <[email protected]>
The code looks good, but as discussed, I think the resulting image manifest has the For example,
But I think, according to the spec this should be:
Potentially related: google/go-containerregistry#1537, google/go-containerregistry#1832 |
looks like its being worked on: |
allow the config to setup the artifactType when the config mediatype is of empty type