feat: Update SIF from ImageIndex #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtrudg
force-pushed
the
issue-48
branch
6 times, most recently
from
de42d45 to
fbf2ea4
Compare
dtrudg
changed the title
tri-adam
requested changes
Jul 4, 2024
There was a problem hiding this comment.
Left a few comments/questions.
My only other thought here is that it's a shame the GGCR Cache interface only supports caching layers (and not manifests/configs.) Otherwise it might be a nice way to hide some of the complexity of that. Oh well!
dtrudg
force-pushed
the
issue-48
branch
2 times, most recently
from
8e2a254 to
e6b37ce
Compare
Add `sif.Update` which accepts updates a SIF so that its content reflects the ImageIndex passed. Any blobs in the SIF that are not present in the new ImageIndex will be removed from the SIF. Any blobs that are present in the new ImageIndex, but not in the SIF, will be added to the SIF. Blobs that are present in both the SIF and the new ImageIndex are not re-written. They will remain at their current descriptor location in the SIF. Closes sylabs#48
tri-adam
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
sif.Updatewhich accepts updates a SIF so that its content reflects the ImageIndex passed.Any blobs in the SIF that are not present in the new ImageIndex will be removed from the SIF.
Any blobs that are present in the new ImageIndex, but not in the SIF, will be added to the SIF.
Blobs that are present in both the SIF and the new ImageIndex are not re-written. They will remain at their current descriptor location in the SIF.
Closes https://github.com/sylabs/oci-tools/issues/48feat: Update SIF from ImageIndex
Add
sif.Updatewhich accepts updates a SIF so that its content reflects the ImageIndex passed.Any blobs in the SIF that are not present in the new ImageIndex will be removed from the SIF.
Any blobs that are present in the new ImageIndex, but not in the SIF, will be added to the SIF.
Blobs that are present in both the SIF and the new ImageIndex are not re-written. They will remain at their current descriptor location in the SIF.
Closes #48