mutate: stream tar output from sqfs2tar #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtrudg
force-pushed
the
tar-conv-streaming
branch
2 times, most recently
from
c5c22f1 to
fcdc737
Compare
Stream the tar output from sqfs2tar when performing a SquashFS to TAR layer conversion. This removes the need for one temporary file. Although intended, we cannot remove the SquashFS temporary file by using a named pipe for intput to sqfs2tar. Due to the structure of SquashFS filesystems, sqfs2tar re-reads portions of the input and cannot work from a named pipe that is streaming input. Temporary directory is also now passed by option, per comments in review of sylabs#52. Closes sylabs#57
dtrudg
force-pushed
the
tar-conv-streaming
branch
from
fcdc737 to
d7e6562
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stream the tar output from sqfs2tar when performing a SquashFS to TAR layer conversion. This removes the need for one temporary file.
Although intended, we cannot remove the SquashFS temporary file by using a named pipe for input to sqfs2tar. Due to the structure of SquashFS filesystems, sqfs2tar re-reads portions of the input and cannot work from a named pipe that is streaming input.
Temporary directory is also now passed by option, per comments in review of #52.
Closes #57