Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: readmes #194

Merged
merged 13 commits into from
Jun 12, 2024
Merged

chore: readmes #194

merged 13 commits into from
Jun 12, 2024

Conversation

wainola
Copy link
Contributor

@wainola wainola commented May 10, 2024

Description

Provide readmes with basic instructions and documentation

Related Issue Or Context

Closes: #184

How Has This Been Tested? Testing details.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation

Checklist:

  • I have commented my code, particularly in hard-to-understand areas.
  • I have ensured that all acceptance criteria (or expected behavior) from issue are met
  • I have updated the documentation locally and in sygma-docs.
  • I have added tests to cover my changes.
  • I have ensured that all the checks are passing and green, I've signed the CLA bot

@wainola wainola changed the title Chore/readmes chore: readmes May 10, 2024
@wainola wainola marked this pull request as ready for review May 13, 2024 03:34
mpetrunic
mpetrunic reviewed May 13, 2024
View reviewed changes
packages/widget/README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
packages/react/README.md Outdated Show resolved Hide resolved
packages/widget/README.md Show resolved Hide resolved
wainola and others added 2 commits May 13, 2024 10:10
@wainola @mpetrunic
Update README.md
78685fe 
Co-authored-by: Marin Petrunić <[email protected]>
@wainola @mpetrunic
Update README.md
56ad62d 
Co-authored-by: Marin Petrunić <[email protected]>
haochizzle
haochizzle reviewed May 14, 2024
View reviewed changes
README.md Show resolved Hide resolved
wainola and others added 2 commits June 12, 2024 08:48
@wainola @mpetrunic
Update README.md
3aeedb3 
Co-authored-by: Marin Petrunić <[email protected]>
@wainola @mpetrunic
Update packages/react/README.md
50a0d4d 
Co-authored-by: Marin Petrunić <[email protected]>
saadahmsiddiqui
saadahmsiddiqui reviewed Jun 12, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
haochizzle
haochizzle approved these changes Jun 12, 2024
View reviewed changes
Copy link
Contributor

@haochizzle haochizzle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

just consider the touch yarn.lock aspect xD

@haochizzle haochizzle merged commit 8779129 into main Jun 12, 2024
4 checks passed
@haochizzle haochizzle deleted the chore/readmes branch June 12, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saadahmsiddiqui saadahmsiddiqui saadahmsiddiqui approved these changes

@haochizzle haochizzle haochizzle approved these changes

@Lykhoyda Lykhoyda Awaiting requested review from Lykhoyda Lykhoyda is a code owner

@mpetrunic mpetrunic Awaiting requested review from mpetrunic mpetrunic is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update readmes
4 participants
@wainola @mpetrunic @haochizzle @saadahmsiddiqui