Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File permissions #24

Merged
merged 3 commits into from
Jan 16, 2020
Merged

File permissions #24

merged 3 commits into from
Jan 16, 2020

Conversation

alexdutton
Copy link
Contributor

No description provided.

@alexdutton alexdutton self-assigned this Jan 12, 2020
@codecov
Copy link

codecov bot commented Jan 13, 2020

Codecov Report

Merging #24 into master will increase coverage by 0.2%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master      #24     +/-   ##
=========================================
+ Coverage   91.12%   91.33%   +0.2%     
=========================================
  Files          16       16             
  Lines         462      473     +11     
  Branches       46       46             
=========================================
+ Hits          421      432     +11     
  Misses         27       27             
  Partials       14       14
Impacted Files Coverage Δ
invenio_sword/config.py 100% <ø> (ø) ⬆️
invenio_sword/views.py 90.86% <100%> (+0.28%) ⬆️
invenio_sword/api.py 90.9% <100%> (+0.74%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f72ef5...db618d6. Read the comment docs.

@alexdutton alexdutton marked this pull request as ready for review January 15, 2020 15:51
@alexdutton
Copy link
Contributor Author

This still doesn't fix the permissions issues properly, which I've documented in #25, but it does lead to a tidier file management view implementation, which I'm going to merge for now, until #25 is sorted.

@alexdutton alexdutton merged commit 30b4926 into master Jan 16, 2020
@alexdutton alexdutton deleted the file-permissions branch September 1, 2020 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant