Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permissions issues #25

Open
alexdutton opened this issue Jan 16, 2020 · 0 comments
Open

Permissions issues #25

alexdutton opened this issue Jan 16, 2020 · 0 comments
Labels
help wanted Extra attention is needed

Comments

@alexdutton
Copy link
Contributor

I've so far found permissions in the invenio ecosystem to be rather confusing and difficult to follow.

I've succeeded in mirroring what invenio-deposit does for access control for record-based views, but have struggled with the file-based views, which — to avoid duplication — should make use of the functionality in invenio-records-files.

Invenio's access control is described at https://invenio-access.readthedocs.io/en/latest/usage.html, but in terms of implementation there's a lot of indirection and closures in terms of permissions factories and wrapped ElasticSearch checks.

I think I need to add something to dispatch_request to attach the appropriate needs to the principal before the later permissions checks, but feel this should be easier.

@alexdutton alexdutton added the help wanted Extra attention is needed label Jan 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant