Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: Upgrade nesbot/carbon ^3.0 #45

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kingIZZZY
Copy link
Contributor

@kingIZZZY kingIZZZY commented Dec 31, 2024

Getting errors out of nesbot/carbon codebase under PHP 8.4 which would be solved by upgrading to ^3.0

Could maybe even go up to latest version ^3.8?...

Will also be submitting pull requests for similar Carbon upgrade for the following Hyperf dependencies:

  • hyperf/validation
  • hyperf/crontab
  • hyperf/database

@kingIZZZY
Copy link
Contributor Author

Looks like another Hyperf pull request was already working on this

Although it's missing some things like hyperf/validation

@huangdijia
Copy link

huangdijia commented Jan 1, 2025

Hyperf does not support PHP8.4 now, but will fully support PHP8.4 and swoole6 in the next major release (3.2).

@kingIZZZY
Copy link
Contributor Author

Very much looking forward for that!
I hope laravel-hyperf keeps up with those newer versions ASAP 🙏

(when does Hyperf 3.2 come out? Is there a release schedule / plan?)

@albertcht albertcht added the draft label Jan 1, 2025
@albertcht albertcht changed the title Upgrade nesbot/carbon ^3.0 Draft: Upgrade nesbot/carbon ^3.0 Jan 1, 2025
@albertcht
Copy link
Member

Hi @kingIZZZY ,

Yes, we will follow up the Hyperf releases. Laravel Hyperf will support Carbon 3 once it's supported in Hyperf.
Before that I will remain this PR pending for a while.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants