Fix reference/resource dtor

swoole · Feb 19, 2024 · bee6a5a · bee6a5a
1 parent 5e69b52
commit bee6a5a
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 2 deletions.
diff --git a/src/python/reference.cc b/src/python/reference.cc
@@ -46,7 +46,6 @@ static int Reference_init(ZendReference *self, PyObject *args, PyObject *kwds) {
 
 static void Reference_dtor(PyObject *pv) {
  ZendReference *self = (ZendReference *) pv;
- phpy::php::del_object(pv);
  zval_ptr_dtor(&self->reference);
  ZVAL_NULL(&self->reference);
 }
@@ -58,6 +57,7 @@ static PyObject *Reference_get(ZendReference *self, PyObject *args) {
 static void Reference_destroy(ZendReference *self) {
  zval_ptr_dtor(&self->reference);
  Py_TYPE(self)->tp_free((PyObject *) self);
+ phpy::php::del_object((PyObject *) self);
 }
 
 bool py_module_reference_init(PyObject *m) {

diff --git a/src/python/resource.cc b/src/python/resource.cc
@@ -32,7 +32,6 @@ static PyTypeObject ZendResourceType = { PyVarObject_HEAD_INIT(NULL, 0) };
 
 static void Resource_dtor(PyObject *pv) {
  ZendResource *self = (ZendResource *) pv;
- phpy::php::del_object(pv);
  zval_ptr_dtor(&self->resource);
  ZVAL_NULL(&self->resource);
 }