Refactor: Rename parameter in method \Swoole\MultibyteStringObject::s…

…ubstr() for consistency.

CHANGELOG.md

@@ -3,6 +3,8 @@
 Changed:
 
 * Refactor: Rename parameter in method `\Swoole\Database\PDOStatementProxy::setFetchMode()` for consistency.
+* Refactor: Rename parameter in method `\Swoole\MultibyteStringObject::substr()` for consistency.
+* Refactor: Enhance method `\Swoole\FastCGI\Message::withBody()` with explicit parameter type.
 
 ## 5.1.2 (2024-01-24)
 

src/core/MultibyteStringObject.php

@@ -44,14 +44,11 @@ public function ipos(string $needle, int $offset = 0, ?string $encoding = null):
  }
 
  /**
- * @todo First parameter will be renamed to $start in Swoole 5.2+.
- * @todo This method will be refactored and marked as final in Swoole 5.2+.
- * 1. It should use keyword self instead of static.
- * 2. Don't use function func_get_args().
+ * @see https://www.php.net/mb_substr
  */
- public function substr(int $offset, ?int $length = null, ?string $encoding = null): static
+ public function substr(int $start, ?int $length = null, ?string $encoding = null): self
  {
- return new static(mb_substr($this->string, ...func_get_args())); // @phpstan-ignore new.static
+ return new self(mb_substr($this->string, $start, $length, $encoding));
  }
 
  /**

src/core/StringObject.php

@@ -107,7 +107,7 @@ public function rtrim(): self
  */
  public function substr(int $offset, ?int $length = null)
  {
- return new static(substr($this->string, ...func_get_args())); // @phpstan-ignore new.static
+ return new static(substr($this->string, $offset, $length)); // @phpstan-ignore new.static
  }
 
  public function repeat(int $times): static