-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OWP ESPWebServer library updated #23
Open
MrDornback
wants to merge
13
commits into
switchdoclabs:master
Choose a base branch
from
MrDornback:OWP_AHD
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modification to use ESPWebServer, in place of ESP8266WebServer. ESPWebServer is an updated version, released on the gitHub ESP8266 repository, which is related to a redeclaration of HTTP_HEAD issue, when using new ESP8266 core. ** Unknown if/when my updates to the library will be merged. https://github.com/esp8266/ESPWebServer
Updated code to use HTTP_HEADER_START and HTTP_HEADER_END. HTTP_HEAD results in a conflict with ESP8266WebServer.
Included updated ESPWebServer library files. When including this library, this code compiles.
* HTTP_HEAD-Fix: HTTP_HEAD Fix
Added WiFiManager.statusStr(int status) to WiFiManager.h .cpp, in order to display the WiFi.status() as a string output with the "[status#] short name" Also updated WiFiManager::connectWifi() and WiFiManager::waitForConnectResult() to display the full status in the WM_DEBUG output. ** These updates can be merged directly with the master brance, but are also compatible with my OWP_AHD and HTTP_HEAD-Fix forks.
* master: WiFiManager.statusStr(int status) add Set theme jekyll-theme-slate
Updated teh variable name for AM2315 values from dewpoint to AM2315_Dewpoint.
This reverts commit ebfc243.
This reverts commit 18a0ecc.
Updated variable name from dewpoint to AM2315_Dewpoint to be consistent with the other AM2315 sensor value variables AM2315_Temperature and AM2315_Humidity.
Found errors in code and eroneous comments that needed to be removed, which I believe were entered into my code by gitHub Desktop. Also, fixed an error with HTTP_HEAD conflict in wifiManager.h .cpp by changing reference from ESP8266Webserver.h to ESPWebServer.h. Included ESPWebServer library in Essentials folder in the root of the OurWeatherPlus code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to an HTTP_HEAD redeclaration error I was receiving, which was resulting in a reset loop whenever I would connect to the AP, I traced it back to ESP8266WebServer library.
There is an updated library (ESPWebServer), what was not fully completed with the name changes, so I completed that and included it.
I have also forked and published the changes directly with ESP8266 for that library.