Feature: prevent arrow key events from bubbling to document

swisstopo · Nov 19, 2024 · d9a3e54 · d9a3e54
1 parent a6f5053
commit d9a3e54
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/ui/src/elements/ngm-cam-configuration.ts b/ui/src/elements/ngm-cam-configuration.ts
@@ -157,6 +157,7 @@ export class NgmCamConfiguration extends LitElementI18n {
     super.disconnectedCallback();
   }
 
+
   updated(changedProperties: PropertyValues) {
     if (this.viewer && !this.unlistenPostRender) {
       this.scene = this.viewer.scene;
@@ -172,7 +173,7 @@ export class NgmCamConfiguration extends LitElementI18n {
   updateFromCamera() {
     const camera = this.scene!.camera;
     const pc = camera.positionCartographic;
-    const altitude = this.scene!.globe.getHeight(pc) || 0;
+    const altitude = this.scene!.globe.getHeight(pc) ?? 0;
     this.elevation = pc.height - altitude;
     this.pitch = Math.round(CesiumMath.toDegrees(camera.pitch));
     let heading = Math.round(CesiumMath.toDegrees(camera.heading));
@@ -187,7 +188,7 @@ export class NgmCamConfiguration extends LitElementI18n {
   }
 
   updateHeight(value: number) {
-    const altitude = this.scene!.globe.getHeight(this.scene!.camera.positionCartographic) || 0;
+    const altitude = this.scene!.globe.getHeight(this.scene!.camera.positionCartographic) ?? 0;
     NavToolsStore.setCameraHeight(value + altitude);
   }
 
@@ -342,6 +343,7 @@ export class NgmCamConfiguration extends LitElementI18n {
                      step=${c.step}
                      .value=${c.getValue()}
                      @input=${c.onSliderChange}
+                     @keydown="${(e) => { if (e.key === 'ArrowLeft' || e.key === 'ArrowRight') e.stopPropagation(); }}"
               />
             </div>
           </div>`)}