Fix: sonar cloud quick fixes

swisstopo · Nov 26, 2024 · 43046b4 · 43046b4
1 parent 1e56a17
commit 43046b4
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 10 deletions.
diff --git a/ui/src/elements/ngm-layer-legend.ts b/ui/src/elements/ngm-layer-legend.ts
@@ -27,12 +27,11 @@ export class NgmLayerLegend extends LitElementI18n {
 
   getImageLegend() {
     const legendImage = this.config.legend ? `https://api.geo.admin.ch/static/images/legends/${this.config.legend}_${i18next.language}.png` : undefined;
-    return legendImage ? html`
+    return legendImage && html`
       <div class="ngm-legend-container">
         <div>${i18next.t('dtd_legend')}</div>
         <div class="ngm-legend-image"><img src="${legendImage}"></div>
-      </div>
-    ` : null;
+      </div>`;
   }
 
   async getWmtsLegend() {

diff --git a/ui/src/elements/ngm-object-information.ts b/ui/src/elements/ngm-object-information.ts
@@ -22,13 +22,8 @@ export class NgmObjectInformation extends LitElementI18n {
     this.hidden = !this.opened;
 
     QueryStore.objectInfo.subscribe(info => {
-      if (info) {
-        this.info = info;
-        this.opened = true;
-      } else if (this.opened) {
-        this.opened = false;
-        this.info = undefined;
-      }
+      this.info = info;
+      this.opened = info == null;
     });
 
     document.addEventListener('keydown', (event) => {