Adapt csv import #1772
Merged
Adapt csv import #1772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MiraGeowerkstatt
force-pushed
the
adapt-csv-import
branch
from
65d48ae to
55747d2
Compare
Lehats
reviewed
Dec 17, 2024
danjov
requested changes
Dec 19, 2024
Lehats
previously approved these changes
Dec 19, 2024
|
danjov
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@danjov @Lehats mit diesem PR habe ich den vorhandenen CSV Import so angepasst, dass exportierte CSV files so wie sie sind wieder importiert werden können. Die header sind jetzt camel case statt snake case und werden direkt gemapped. Ich habe am Import selber nichts geändert, das heisst snake case ist für alle properties (ausser den custom identifiers) theoretisch weiter unterstützt.
Was meint ihr dazu?
(Achtung ich vergleiche hier mit einem noch nicht gemergedn branch "add-tvd-and-custom-ids" auf dem dieser aufbaut).