Remove isViewer flag

CHANGELOG.md

@@ -20,6 +20,7 @@
 - It is now possible to restart a workflow from every publication status.
 - Renamed codelist entries for casing type and casing material.
 - Upgraded to PostgreSQL 15 and PostGIS 3.4.
+- Removed unused `IsViewer` flag from user.
 
 ### Fixed
 

config/create-user.sql

@@ -1,7 +1,7 @@
 INSERT INTO bdms.users
-    (created_usr, admin_usr, viewer_usr, username, settings_usr, firstname, lastname)
+    (created_usr, admin_usr, username, settings_usr, firstname, lastname)
 VALUES
     (
-        NOW(), true, true, 'GeoWerkstatt',
+        NOW(), true, 'GeoWerkstatt',
         '{"filter": {"custom": {"borehole_identifier": true, "project_name": true, "landuse": true, "alternate_name": true, "canton": true, "city": true}, "restriction": true, "restriction_until": true, "extended": {"original_name": true, "method": true, "status": true}, "kind": true, "elevation_z": true, "length": true, "drilling_date": true, "zoom2selected": true}, "boreholetable": {"orderby": "original_name", "direction": "ASC"}, "eboreholetable": {"orderby": "creation", "direction": "DESC"}, "map": {"explorer": {}, "editor": {}}, "appearance": {"explorer": 1}}',
         'GeoWerkstatt', 'user');

src/api-legacy/v1/basehandler.py

@@ -66,9 +66,7 @@ async def prepare(self):
                             ELSE
                                 TRUE
                         END AS terms,
-                        COALESCE(
-                            viewer_usr, FALSE
-                        ) as viewer,
+                        TRUE as viewer,
                         COALESCE(
                             admin_usr, FALSE
                         ) as admin,

src/api/Authentication/DatabaseAuthenticationClaimsTransformation.cs

@@ -36,7 +36,7 @@ public async Task<ClaimsPrincipal> TransformAsync(ClaimsPrincipal principal)
         {
             claimsIdentity.AddClaim(new Claim(ClaimTypes.Role, PolicyNames.Admin));
         }
-        else if (authenticatedUser.IsViewer)
+        else
         {
              claimsIdentity.AddClaim(new Claim(ClaimTypes.Role, PolicyNames.Viewer));
         }
@@ -52,7 +52,7 @@ public async Task<ClaimsPrincipal> TransformAsync(ClaimsPrincipal principal)
         if (subjectId is null)
             return null;
 
-        var user = dbContext.Users.SingleOrDefault(u => u.SubjectId == subjectId) ?? new User { SubjectId = subjectId, IsViewer = true };
+        var user = dbContext.Users.SingleOrDefault(u => u.SubjectId == subjectId) ?? new User { SubjectId = subjectId };
         user.FirstName = principal.Claims.FirstOrDefault(c => c.Type == ClaimTypes.GivenName)?.Value ?? user.FirstName;
         user.LastName = principal.Claims.FirstOrDefault(c => c.Type == ClaimTypes.Surname)?.Value ?? user.LastName;
         user.Name = $"{user.FirstName[0]}. {user.LastName}";

src/api/Authentication/PolicyNames.cs

@@ -13,7 +13,7 @@ public static class PolicyNames
     public const string Admin = "Admin";
 
     /// <summary>
-    /// Users with <see cref="User.IsViewer"/> set to <c>true</c>.
+    /// Users with <see cref="User.IsAdmin"/> set to <c>false</c>.
     /// </summary>
     public const string Viewer = "Viewer";
 }