Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move icons to src #1408

Merged
merged 1 commit into from
Jul 30, 2024
Merged

Move icons to src #1408

merged 1 commit into from
Jul 30, 2024

Conversation

tschumpr
Copy link
Contributor

Fixes the following problem:
Assets in public directory cannot be imported from JavaScript.
If you intend to import that asset, put the file in the src directory, and use /src/icons/filter.svg?react instead of /public/icons/filter.svg?react.
If you intend to use the URL of that asset, use /icons/filter.svg?url&react.

Assets in public directory cannot be imported from JavaScript.
If you intend to import that asset, put the file in the src directory,
and use /src/icons/filter.svg?react instead of
/public/icons/filter.svg?react.
If you intend to use the URL of that asset, use
/icons/filter.svg?url&react.
@tschumpr tschumpr requested a review from danjov July 30, 2024 05:56
@tschumpr tschumpr merged commit 4e9ddfa into main Jul 30, 2024
12 checks passed
@tschumpr tschumpr deleted the fix-vite-error branch July 30, 2024 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants