Prevent saving invalid form (#1011)

src/client/cypress/e2e/editor/completion.cy.js

@@ -276,13 +276,18 @@ describe("completion crud tests", () => {
       expect(location.hash).to.eq("#casing");
     });
 
-    // new to existing: changes can be reverted in prompt
+    // new to existing: save option is disabled if form is invalid
     addCompletion();
     cy.location().should(location => {
       expect(location.pathname).to.eq(`/editor/${boreholeId}/completion/new`);
       expect(location.hash).to.eq("");
     });
     setInput("name", "new completion");
+    setTab(0);
+    cy.get('[data-cy="prompt-button-save"]').should("be.disabled");
+    handlePrompt("Unsaved changes", "cancel");
+
+    // new to existing: changes can be reverted in prompt
     setSelect("kindId", 1);
     setTab(0);
     handlePrompt("Unsaved changes", "reset");
@@ -317,16 +322,24 @@ describe("completion crud tests", () => {
     setTab(2);
     deleteCompletion();
     handlePrompt("Do you really want to delete this completion?", "delete");
+    cy.location().should(location => {
+      expect(location.pathname).to.eq(
+        `/editor/${boreholeId}/completion/${completion2Id}`,
+      );
+      expect(location.hash).to.eq("#casing");
+    });
 
     // existing editing to new: no prompt should be displayed when no changes have been made, form should be reset
     setTab(0);
-    startEditing();
+    cy.wait("@casing_GET");
+    isTabSelected(0);
     cy.location().should(location => {
       expect(location.pathname).to.eq(
         `/editor/${boreholeId}/completion/${completion1Id}`,
       );
       expect(location.hash).to.eq("#casing");
     });
+    startEditing();
     cy.get(`[data-cy="name-formInput"]`).click();
     addCompletion();
     evaluateInput("name", "");

src/client/public/locale/de/common.json

@@ -362,7 +362,7 @@
   "uploaded": "Hochgeladen",
   "uploadNewFile": "Hochladen einer neuen Datei",
   "unsavedChangesTitle": "Ungespeicherte Änderungen",
-  "unsavedChangesMessage": "Sie haben ungespeicherte Änderungen. Wollen Sie sie speichern?",
+  "unsavedChangesMessage": "Sie haben ungespeicherte Änderungen. Wie möchten Sie fortfahren?",
   "unselectAll": "Alle abwählen",
   "user": "Benutzer",
   "username": "Benutzername",

src/client/public/locale/en/common.json

@@ -362,7 +362,7 @@
   "uploaded": "Uploaded",
   "uploadNewFile": "Upload a new file",
   "unsavedChangesTitle": "Unsaved changes",
-  "unsavedChangesMessage": "You have unsaved changes. Do you want to save them?",
+  "unsavedChangesMessage": "You have unsaved changes. How would you like to proceed?",
   "unselectAll": "Unselect all",
   "user": "User",
   "username": "Username",

src/client/public/locale/fr/common.json

@@ -362,7 +362,7 @@
   "uploaded": "Téléchargé",
   "uploadNewFile": "Télécharger un nouveau fichier",
   "unsavedChangesTitle": "Changements non enregistrés",
-  "unsavedChangesMessage": "Vous avez des modifications non enregistrés. Voulez-vous les enregistrer?",
+  "unsavedChangesMessage": "Vous avez des modifications non enregistrés. Comment souhaitez-vous continuer?",
   "unselectAll": "Tout désélectionner",
   "user": "Utilisateur",
   "username": "Nom d'utilisateur",

src/client/public/locale/it/common.json

@@ -362,7 +362,7 @@
   "uploaded": "Caricamento",
   "uploadNewFile": "Caricare un nuovo file",
   "unsavedChangesTitle": "Modifiche non salvate",
-  "unsavedChangesMessage": "Le modifiche non sono state salvate. Volete salvarle?",
+  "unsavedChangesMessage": "Le modifiche non sono state salvate. Come volete procedere?",
   "unselectAll": "Deseleziona tutto",
   "user": "Utente",
   "username": "Nome utente",

src/client/src/commons/form/borehole/completion/completionHeaderInput.js

@@ -180,6 +180,7 @@ const CompletionHeaderInput = props => {
           },
           {
             label: "save",
+            disabled: !formMethods.formState.isValid,
             action: () => {
               formMethods.handleSubmit(submitForm)();
             },

src/client/src/components/prompt/prompt.js

@@ -39,6 +39,7 @@ const Prompt = props => {
               }
               setOpen(false);
             }}
+            disabled={action.disabled === true}
             data-cy={"prompt-button-" + action.label}>
             {t(action.label)}
           </PromptButton>