Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix/various #23

Merged
merged 13 commits into from
Nov 3, 2024
Merged

Bugfix/various #23

merged 13 commits into from
Nov 3, 2024

Conversation

sabberworm
Copy link
Collaborator

@sabberworm sabberworm commented Oct 31, 2024 •
edited
Loading

  • Fine-grained control over running the sub-pipeline of a createChildNode hop when the child node already exists
  • Fix bug when moving a node to the root
  • Add tests for a few of the hop types not yet under test
  • Keep order of renamed node (when moveNode is used to move to the same parent as before). Closes Bug: moveNode doesn’t keep node order #16
  • Ensure copyNode gracefully handles all cases where a node was copied into itself
  • Allow each to loop over primitive arrays

@sabberworm
Copy link
Collaborator Author

I would be cool if we had unit tests for all the hop types. Most of the improvements done in this PR came about because I wanted to write a unit test.

@sabberworm
fix(runner): refactor copyNode hop
c08663c 
Now uses serialization/deserialization for the copy
This gracefully handles all weird edge cases
(like copying a node into itself and overwriting an existing node)
@sabberworm sabberworm merged commit 0b3dc91 into main Nov 3, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SgiobairOg SgiobairOg SgiobairOg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: moveNode doesn’t keep node order
2 participants
@sabberworm @SgiobairOg