Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow 'auto' to be passed as a height #2133

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Whatshiywl
Copy link

@Whatshiywl Whatshiywl commented Jan 2, 2023

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior? (You can also link to an open issue here)
The headerHeight and footerHeight inputs of ngx-datatable accept the 'auto' value as well as numbers, going as far as verifying if their values match that specific string. However, their current type signature allows for numbers only. This type conflict pops up when using strictTemplates as an Angular Compiler Option.

What is the new behavior?
The two aforementioned inputs will now allow the 'auto' value to be passed without incurring in build errors when template type checking is enabled.

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

Copy link
Contributor

@achimha achimha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if headerHeight/footerHeight is 'auto', the calculation with height = height - (this.footerHeight as number) will not work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants