Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom colors for linear-scaled charts and fix incorrect maximum gradient stop bug #1911

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

Lyq322
Copy link

@Lyq322 Lyq322 commented Oct 30, 2023

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior? (You can also link to an open issue here)
Issue #1910 and #1909

What is the new behavior?
Custom color is now supported by linear-scaled charts, including all linear-scaled bar charts, all linear-scaled area charts, linear-scaled line chart, linear-scaled polar chart, linear-scaled bubble chart, linear-scaled box chart, heat map, heat calendar.
Vertical bar chart:
Screenshot 2023-10-29 at 8 37 58 PM
Heat map:
Screenshot 2023-10-29 at 8 41 11 PM

For linear-scaled charts, the maximum gradient color stop is now in the color scheme and matches the maximum gradient color stop on the legend.
Before:
image
After:
Screenshot 2023-10-29 at 8 42 37 PM

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

Includes all bar charts, line chart, all area charts, bubble chart, heat map and calendar and box chart.
Place gradient stop 1 at minimum and gradient stop 2 at maximum
Input is the two gradient stops
Last color stop of linear gradient is taking up 2 stops instead of one stop for each color.
@Lyq322 Lyq322 changed the title Linear custom colors Custom colors for linear-scaled charts and fix incorrect maximum gradient stop bug Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant