Display Total Value and Custom Label in Pie Chart #1893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Displays total inside pie chart when display type is doughnut.
Added option and customization to total displayed in pie chart, including font size and display text.
Due to total-number and total-text not in DOM yet when font size was updated
IrisTien
reviewed
Dec 13, 2023
projects/swimlane/ngx-charts/src/lib/pie-chart/pie-chart.component.scss
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| .pieTotal { | ||
| font-weight: 400; |
There was a problem hiding this comment.
Question: do we really need this class? Is it default weight?
There was a problem hiding this comment.
It's not default weight. The default weight is too light/thin:
projects/swimlane/ngx-charts/src/lib/pie-chart/pie-chart.component.ts
Outdated
Show resolved
Hide resolved
|
Can we provide a better title for this pull request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check one with "x")
What is the current behavior? (You can also link to an open issue here)
Issue #1568
Bug when explode slices and doughnut are both true:
What is the new behavior?
Total is displayed inside pie chart. The text "TOTAL" can be changed and font size of both number of text can be customized. The number is shortened using suffixes such as K, M, B and scientific notation (e) for numbers even greater.
New behavior for when both explode slices and doughnut are true:
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: