Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add integration tests for Inline/Expand Macro actions #1206

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add integration tests for Inline/Expand Macro actions #1206

wants to merge 1 commit into from

Conversation

michael-weng
Copy link
Contributor

  • Validate the workflow of user calling Inline/Expand Macro actions on a swift project with macro
  • Add test fixture for swift macro
  • Verify inline macro by asserting on inlined value after calling the action
  • Verify expand macro by asserting expanded macro document contain the right macro

Issue: #1205

@michael-weng
Add integration tests for Inline/Expand Macro actions
dc2b562 
- Validate the workflow of user calling Inline/Expand Macro actions on
a swift project with macro
- Add test fixture for swift macro
- Verify inline macro by asserting on inlined value after calling the
action
- Verify expand macro by asserting expanded macro document contain the
right macro

Issue: swiftlang#1205
@michael-weng
Copy link
Contributor Author

We can probably optimize with background compilation integration test, but let's do that after this is merged and we have a few more lsp related integration tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adam-fowler adam-fowler Awaiting requested review from adam-fowler adam-fowler is a code owner

@0xTim 0xTim Awaiting requested review from 0xTim 0xTim is a code owner

@award999 award999 Awaiting requested review from award999 award999 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@michael-weng