Add Support for Static Fields to Java2Swift tool #61
+34
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktoso
approved these changes
Oct 10, 2024
There was a problem hiding this comment.
Looks good to me but I'll give @DougGregor a chance to answer the question asked 👍
ktoso
reviewed
Oct 10, 2024
| /// ```swift | ||
| /// @JavaClass("org.swift.example.HelloSwift") | ||
| /// struct HelloSwift { | ||
| /// @JavaField |
There was a problem hiding this comment.
Suggested change
| /// @JavaField | |
| /// @JavaStaticField |
shouldn't the var be static as well?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #39
This adds support to adding static fields to the Java2Swift tool. The issue recommends adding a
@JavaStaticFieldmacro, but it looks like due to the fact that the subscript created by theJavaFieldmacro works for static properties when defined on aJavaClass, so I'm not sure a@JavaStaticFieldreally buys anything here, so I'm open to removing it.Same testing as in #55 (since that one also adds a static String).
I also noticed that we had a
staticMethodsarray, but were re-requesting all methods in theJava2Swifttool when handling static methods, so I updated it to just use thestaticMethodsarray to simplify the code a bit.