This repository has been archived by the owner on Oct 22, 2024. It is now read-only.
Feature: Implement retries mechanism #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swellmike
reviewed
May 14, 2024
swellmike
approved these changes
May 14, 2024
swellmike
reviewed
May 14, 2024
awwit
approved these changes
May 14, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Sometimes requests could fail because of network, in this case we can add option
retries(default 0), which tries to resend request n-times and throws error is all attempts failed.Testing
To simulate bad network I tried to close socket with 20% chance
Before
before.mov
After
after.mov
Also added unit tests