Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding a link to an online book as a ressource #900

Merged
merged 2 commits into from
Sep 21, 2024

Conversation

bervelin-lumesa
Copy link
Contributor

If this pull request addresses an open issue on the repository, please add 'Closes #NN' below, where NN is the issue number.

Please briefly summarise the changes made in the pull request, and the reason(s) for making these changes.

If any relevant discussions have taken place elsewhere, please provide links to these.

For more guidance on how to contribute changes to a Carpentries project, please review the Contributing Guide and Code of Conduct.

Please keep in mind that lesson Maintainers are volunteers and it may be some time before they can respond to your contribution. Although not all contributions can be incorporated into the lesson materials, we appreciate your time and effort to improve the curriculum. If you have any questions about the lesson maintenance process or would like to volunteer your time as a contribution reviewer, please contact The Carpentries Team at [email protected].

Copy link

github-actions bot commented Sep 11, 2024

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/swcarpentry/r-novice-gapminder/compare/md-outputs..md-outputs-PR-900

The following changes were observed in the rendered markdown documents:

 01-rstudio-intro.md |  2 +-
 02-project-intro.md |  2 +-
 03-seeking-help.md  |  2 +-
 12-dplyr.md         |  1 +
 md5sum.txt          | 50 +++++++++++++++++++++++++-------------------------
 5 files changed, 29 insertions(+), 28 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2024-09-21 23:45:58 +0000

Copy link
Contributor

@skanwal skanwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Seems like a great resource.

@naupaka
Copy link
Member

naupaka commented Sep 20, 2024

I agree this is a nice addition and should be good to merge, but it looks like one of the automated checks is failing. I am not sure what the error is referring to - perhaps @froggleston would have a better sense? It seems like a very simple/straightforward PR.

@froggleston
Copy link
Contributor

This is due to the update-artifact workflow being updated to v4 which needed a subsequent fix that was part of the 0.16.7 release, so this PR perhaps was based on a version of the workflow that is old? If you pull in the new workflow into this PR it should work?

github-actions bot pushed a commit that referenced this pull request Sep 21, 2024
@naupaka
Copy link
Member

naupaka commented Sep 21, 2024

@froggleston yup that did it, thanks!

@naupaka naupaka merged commit 38bf6ff into swcarpentry:main Sep 21, 2024
3 checks passed
@naupaka
Copy link
Member

naupaka commented Sep 21, 2024

Thanks @bervelin-lumesa for the contribution!

github-actions bot pushed a commit that referenced this pull request Sep 21, 2024
Auto-generated via {sandpaper}
Source  : 38bf6ff
Branch  : main
Author  : Naupaka Zimmerman <[email protected]>
Time    : 2024-09-21 23:49:55 +0000
Message : Merge pull request #900 from bervelin-lumesa/patch-1

adding a link to an online book as a ressource
github-actions bot pushed a commit that referenced this pull request Sep 21, 2024
Auto-generated via {sandpaper}
Source  : aabea31
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-09-21 23:52:04 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 38bf6ff
Branch  : main
Author  : Naupaka Zimmerman <[email protected]>
Time    : 2024-09-21 23:49:55 +0000
Message : Merge pull request #900 from bervelin-lumesa/patch-1

adding a link to an online book as a ressource
@bervelin-lumesa
Copy link
Contributor Author

@naupaka you're welcome

github-actions bot pushed a commit that referenced this pull request Sep 24, 2024
Auto-generated via {sandpaper}
Source  : 38bf6ff
Branch  : main
Author  : Naupaka Zimmerman <[email protected]>
Time    : 2024-09-21 23:49:55 +0000
Message : Merge pull request #900 from bervelin-lumesa/patch-1

adding a link to an online book as a ressource
github-actions bot pushed a commit that referenced this pull request Sep 24, 2024
Auto-generated via {sandpaper}
Source  : 3505082
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-09-24 00:17:04 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 38bf6ff
Branch  : main
Author  : Naupaka Zimmerman <[email protected]>
Time    : 2024-09-21 23:49:55 +0000
Message : Merge pull request #900 from bervelin-lumesa/patch-1

adding a link to an online book as a ressource
github-actions bot pushed a commit that referenced this pull request Oct 1, 2024
Auto-generated via {sandpaper}
Source  : 3505082
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-09-24 00:17:04 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 38bf6ff
Branch  : main
Author  : Naupaka Zimmerman <[email protected]>
Time    : 2024-09-21 23:49:55 +0000
Message : Merge pull request #900 from bervelin-lumesa/patch-1

adding a link to an online book as a ressource
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants