-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(es/preset-env): Update preset-env data #9573
Conversation
🦋 Changeset detectedLatest commit: e402f9e The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
["esnext.composite-symbol", SYMBOL_DEPENDENCIES] | ||
), | ||
fetch: define(null, PROMISE_DEPENDENCIES), | ||
globalThis: define("global-this", ["es.global-this", "esnext.global-this"]), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The source of these new codes are https://github.com/babel/babel/blob/e498bee10f0123bb208baa228ce6417542a2c3c4/packages/babel-preset-env/src/polyfills/corejs3/built-in-definitions.js but I'm not sure if this is correct.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's obsolete definitions. Actual definitions here https://github.com/babel/babel-polyfills/blob/main/packages/babel-plugin-polyfill-corejs3/src/built-in-definitions.ts
CodSpeed Performance ReportMerging #9573 will degrade performances by 7.75%Comparing Summary
Benchmarks breakdown
|
@@ -1,6 +1,6 @@ | |||
require("core-js/modules/es.array.at.js"); | |||
require("core-js/modules/es.regexp.exec.js"); | |||
require("core-js/modules/es.string.at-alternative.js"); | |||
require("core-js/modules/es.string.at.js"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
core-js
doesn't have a module with this name.
require("core-js/modules/es.object.to-string.js"); | ||
document.querySelectorAll('div').forEach(function(el) { | ||
console.log(el); | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right. I'll reopen it.
Description:
Related issue: