Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(es/tsc): Support for tsc multi-file unit tests #5316

Merged
merged 5 commits into from
Jul 29, 2022

Conversation

magic-akari
Copy link
Member

Description:

BREAKING CHANGE:

Related issue (if exists):

@magic-akari magic-akari marked this pull request as ready for review July 27, 2022 06:55
@magic-akari magic-akari marked this pull request as draft July 27, 2022 07:57
@magic-akari magic-akari marked this pull request as ready for review July 27, 2022 09:17
@@ -0,0 +1,12 @@
// @filename: file.tsx
//!
//! x Unexpected token `a`. Expected jsx identifier
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

facebook/jsx#139

Maybe it's better to correct error reporter.

Unexpected token `\u0061`. Expected jsx identifier

@@ -1,6 +1,6 @@
//@Filename: decls.ts
// Ambient external module with export assignment
// Ambient external import declaration referencing ambient external module using top level module name
// Ambient external import declaration referencing ambient external module using top level module name
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

weird spaces
swc playground

//! 9 | interface Thing { }
//! 10 | }
//! 11 | declare module 'react-router' {
//! 12 | export = ReactRouter;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 it's a bug.
We should not handle anything in declare module
swc playground

@magic-akari magic-akari changed the title test(es/tsc): support tsc @FileName directives test(es/tsc): Support for tsc multi-file unit tests Jul 27, 2022
@kdy1 kdy1 added this to the Planned milestone Jul 28, 2022
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!


swc-bump:

  • ''

@kdy1 kdy1 merged commit 81ac366 into swc-project:main Jul 29, 2022
kdy1 pushed a commit to kdy1/swc that referenced this pull request Jul 29, 2022
@kdy1 kdy1 modified the milestones: Planned, v1.2.221, v1.2.222 Jul 31, 2022
@magic-akari magic-akari deleted the test/tsc branch September 3, 2022 07:52
@swc-project swc-project locked as resolved and limited conversation to collaborators Oct 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants