Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to upstream tinywl #23

Merged
merged 2 commits into from
Jan 23, 2024
Merged

Update to upstream tinywl #23

merged 2 commits into from
Jan 23, 2024

Conversation

shtirlic
Copy link
Contributor

@shtirlic shtirlic commented Jan 5, 2024

  • Use Scene Graph for rendering
  • Use golang container/list for toplevels
  • Follow upstream implementation as close as possible
  • Include all upstream comments to the code
  • Add more upstream protocol methods to go-wlroots lib
  • Separate wlroots API to the same structure as upstream
  • Use slog for logging (tint will be used when fixed in upstream Fields names are not printed for C structures lmittmann/tint#55)
  • Closes Poorly comented #17

@shtirlic shtirlic marked this pull request as draft January 6, 2024 07:28
@shtirlic shtirlic force-pushed the master branch 6 times, most recently from 66e3862 to 8134d99 Compare January 7, 2024 09:59
@shtirlic shtirlic changed the title WIP: update to upstream tinywl Update to upstream tinywl Jan 7, 2024
@shtirlic shtirlic marked this pull request as ready for review January 7, 2024 09:59
Copy link
Contributor

@nbsp nbsp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good ^^ i was actually working on this same PR idea :)
just a nitpick but the rest seems nice

wlroots/xwayland.go Show resolved Hide resolved
@nbsp
Copy link
Contributor

nbsp commented Jan 7, 2024

also, maybe split this to a few atomic commits (if that's even possible at this scale)? thinking about wlroots' contributing guide:

This means that every commit should be small, digestible, stand-alone, and functional.

@shtirlic
Copy link
Contributor Author

shtirlic commented Jan 8, 2024

also, maybe split this to a few atomic commits (if that's even possible at this scale)? thinking about wlroots' contributing guide:

This means that every commit should be small, digestible, stand-alone, and functional.

True, but not this time unfortunately, after this PR get merged, the changes can be done it fractional commits.

@shtirlic
Copy link
Contributor Author

shtirlic commented Jan 8, 2024

@alexbakker did you have a chance to look ?

wlroots/compositor.go Outdated Show resolved Hide resolved
wlroots/compositor.go Outdated Show resolved Hide resolved
wlroots/compositor.go Outdated Show resolved Hide resolved
wlroots/scene.go Show resolved Hide resolved
wlroots/scene.go Show resolved Hide resolved
wlroots/scene.go Show resolved Hide resolved
wlroots/backend.go Show resolved Hide resolved
wlroots/backend.go Show resolved Hide resolved
wlroots/scene.go Outdated Show resolved Hide resolved
@shtirlic shtirlic force-pushed the master branch 2 times, most recently from ca2bfb0 to 4295455 Compare January 8, 2024 10:43
@shtirlic
Copy link
Contributor Author

ping @alexbakker , is there are anything I can do more for this PR ?

Copy link
Member

@alexbakker alexbakker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does much more than just "update to upstream tinywl" 😉.

Anyway, LGTM.

@alexbakker alexbakker merged commit 706ab99 into swaywm:master Jan 23, 2024
1 check passed
@shtirlic
Copy link
Contributor Author

yes, sorry for that, in future I will be more precise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Poorly comented
3 participants