-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to upstream tinywl #23
Conversation
66e3862
to
8134d99
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good ^^ i was actually working on this same PR idea :)
just a nitpick but the rest seems nice
also, maybe split this to a few atomic commits (if that's even possible at this scale)? thinking about wlroots' contributing guide:
|
True, but not this time unfortunately, after this PR get merged, the changes can be done it fractional commits. |
@alexbakker did you have a chance to look ? |
ca2bfb0
to
4295455
Compare
ping @alexbakker , is there are anything I can do more for this PR ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This does much more than just "update to upstream tinywl" 😉.
Anyway, LGTM.
yes, sorry for that, in future I will be more precise. |
Scene Graph
for renderingcontainer/list
for toplevelsgo-wlroots
lib