wip

swan-amazon · Sep 6, 2024 · fcd9b6d · fcd9b6d
1 parent 649ce59
commit fcd9b6d
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 13 deletions.
diff --git a/src/app/clusters/general-commissioning-server/general-commissioning-server.cpp b/src/app/clusters/general-commissioning-server/general-commissioning-server.cpp
@@ -439,19 +439,15 @@ bool emberAfGeneralCommissioningClusterSetTCAcknowledgementsCallback(
 
     Commands::SetTCAcknowledgementsResponse::Type response;
     response.errorCode = CheckTermsAndConditionsAcknowledgementsState(termsAndConditionsProvider, acceptedTermsAndConditions);
+    CheckSuccess(termsAndConditionsProvider->SetAcceptance(acceptedTermsAndConditions), Failure);
 
-    if (CommissioningErrorEnum::kOk == response.errorCode)
+    if (failSafeContext.IsFailSafeArmed())
     {
-        CheckSuccess(termsAndConditionsProvider->SetAcceptance(acceptedTermsAndConditions), Failure);
-
-        if (failSafeContext.IsFailSafeArmed())
-        {
-            failSafeContext.SetUpdateTermsAndConditionsHasBeenInvoked();
-        }
-        else
-        {
-            CheckSuccess(termsAndConditionsProvider->CommitAcceptance(), Failure);
-        }
+        failSafeContext.SetUpdateTermsAndConditionsHasBeenInvoked();
+    }
+    else
+    {
+        CheckSuccess(termsAndConditionsProvider->CommitAcceptance(), Failure);
     }
 
     commandObj->AddResponse(commandPath, response);

diff --git a/src/python_testing/TC_CGEN_2_5.py b/src/python_testing/TC_CGEN_2_5.py
@@ -17,7 +17,7 @@
 
 # === BEGIN CI TEST ARGUMENTS ===
 # test-runner-runs: run1
-# test-runner-run/run1/app: ${ALL_CLUSTERS_APP}
+# test-runner-run/run1/app: ${TERMS_AND_CONDITIONS_APP}
 # test-runner-run/run1/factoryreset: True
 # test-runner-run/run1/quiet: True
 # test-runner-run/run1/app-args: --KVS kvs1 --trace-to json:${TRACE_APP}.json

diff --git a/src/python_testing/TC_CGEN_2_6.py b/src/python_testing/TC_CGEN_2_6.py
@@ -17,7 +17,7 @@
 
 # === BEGIN CI TEST ARGUMENTS ===
 # test-runner-runs: run1
-# test-runner-run/run1/app: ${ALL_CLUSTERS_APP}
+# test-runner-run/run1/app: ${TERMS_AND_CONDITIONS_APP}
 # test-runner-run/run1/factoryreset: True
 # test-runner-run/run1/quiet: True
 # test-runner-run/run1/app-args: --KVS kvs1 --trace-to json:${TRACE_APP}.json
@@ -81,6 +81,14 @@ async def test_TC_CGEN_2_6(self):
         asserts.assert_equal(
             resp.errorCode, Clusters.GeneralCommissioning.Enums.CommissioningErrorEnum.kTCAcknowledgementsNotReceived, 'Incorrect error code')
 
+        cmd = Clusters.GeneralCommissioning.Commands.SetTCAcknowledgements(1, 0)
+        resp = await self.th1.SendCommand(nodeid=self.dut_node_id, endpoint=0, payload=cmd, timedRequestTimeoutMs=6000)
+        asserts.assert_equal(resp.errorCode, Clusters.GeneralCommissioning.Enums.CommissioningErrorEnum.kRequiredTCNotAccepted, 'Incorrect error code')
+
+        cmd = Clusters.GeneralCommissioning.Commands.CommissioningComplete()
+        resp = await self.th1.SendCommand(nodeid=self.dut_node_id, endpoint=0, payload=cmd, timedRequestTimeoutMs=6000)
+        asserts.assert_equal(
+            resp.errorCode, Clusters.GeneralCommissioning.Enums.CommissioningErrorEnum.kRequiredTCNotAccepted, 'Incorrect error code')
 
 if __name__ == "__main__":
     default_matter_test_main({"pre_commissioning": False})